Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation2 #41

Merged
merged 8 commits into from
Sep 30, 2023
Merged

Allocation2 #41

merged 8 commits into from
Sep 30, 2023

Conversation

bh2smith
Copy link
Owner

Closes #40

@josojo
Copy link
Collaborator

josojo commented Sep 18, 2023

Hey @bh2smith. Thanks for providing this piece of code!

But unfortunately, it does not work out for me:
IF I am running the command FullClaim, then the redeem in the old contract fails -> Since redeeming was only possible, until time x.
IF I am running the command CLAIM, then the claiming works well, but on the new contract: 0xc0fde70a65c7569fe919be57492228dee8cdb585,

Given that it seems we need to a mix from claiming and redeeming:
image
I think one needs to modificate the code even further. Or did this work for you?

Should I help or will you tackle it?

@bh2smith
Copy link
Owner Author

bh2smith commented Sep 18, 2023

I believe I manually modified it to exclude some parts that didn't work. At the time I was only concerned with one time use. Maybe since the V1 claim period is over we can simply remove it permanently.

I won't have much time to look into this soon, would love if you could help out!

Comment on lines +39 to +40
# all other tags are beyond the claim period
if allocation.tag == "user_v2"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely where you were experiencing issues @josojo. try it now.

@bh2smith bh2smith merged commit 0e32e64 into main Sep 30, 2023
1 check passed
@bh2smith bh2smith deleted the allocation2 branch September 30, 2023 08:05
@josojo
Copy link
Collaborator

josojo commented Sep 30, 2023

Nice, it worked Ben. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 2nd Allocation
2 participants