help diagnostics by reporting the position, step and end of the data being decoded #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being decoded when the decoder throws an exception: make those info bits part of the exception message so we can find out *where* the shit hit the fan for much faster problem diagnosis. # Conflicts: # Core/Meta/VersionInfo.cs
|
@GerHobbelt I was just looking though things and noticed this PR sitting. Did you want us to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
help diagnostics by reporting the position, step and end of the data being decoded when the decoder throws an exception: make those info bits part of the exception message so we can find out where the shit hit the fan for much faster problem diagnosis.
This is a fast & shoddy hack done as part of digging up why
run_tests.shwent pear-shaped on MS Windows dev box (#170); the code is merely to showcase the intended functionality: the existing exception was equivalent to ye ole "syntax error" re information content 😉 , which made debugging hard. When I introduced the mention of these offsets into binary input data, I was able to spot the issue immediately.AFAIAC this is more about the idea (making the error reports more informative) than a code submission per se: I know some folks will reel from the (nasty) mixed C/C++ idiom used here in the augmented exception class.