Enforce OSD option

[haslinghuis]

Lots of issues reported with users not reading release notes so decided to enforce OSD option.

[netlify]

✅ Deploy Preview for origin-betaflight-app ready!

Name	Link
🔨 Latest commit	0f54217
🔍 Latest deploy log	https://app.netlify.com/sites/origin-betaflight-app/deploys/673b49f0a6dbc90008ff9e26
😎 Deploy Preview	https://deploy-preview-4251.dev.app.betaflight.com
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[VitroidFPV]

For the wording: as this is meant to be a beginner-accessible feature (most people have no clue what a "MAX7456" is), maybe just Digital and Analog? Other than that, looks great

[VitroidFPV]

SonarCloud is annoying, but most likely fine

[blckmn]

I have added "Group" and "GroupedName" to the results. This will simplify the code here.

[blckmn]

Suggested change

	data.generalOptions = data.generalOptions.filter(option => option.value !== 'USE_FRSKYOSD' && option.value !== 'USE_OSD_SD' && option.value !== 'USE_OSD_HD');
	data.generalOptions = data.generalOptions.filter(option => !option.group);

[blckmn]

Suggested change

	data.osdProtocols = [
	data.osdProtocols = data.generalOptions.filter(option => option.group === 'OSD');

[blckmn]

You can map to a new item, using the groupedName if you want to change the name to a different name.

[blckmn]

https://build.betaflight.com/api/options

[blckmn]

you will also need to cater for the "none" option... so maybe a helper function to add this, and map. note the none option should have an empty value.

[haslinghuis]

@nerdCopter do you have more info on what kind of build? Works with cloud build target

Edit please check again perhaps ckoudBuildOptions was null

[sonarcloud]

Quality Gate failed

Failed conditions
9.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[nerdCopter]

0f54217e works

word Analogue is incorrect, should be Analog

opinion: I feel that Analog or Digital should be default, not None.

[haslinghuis]

@nerdCopter

word Analogue is incorrect, should be Analog

That is how it is named in cloud build API.

opinion: I feel that Analog or Digital should be default, not None.

None is only selected if analog, digital, frsky is not present.

[nerdCopter]

That is how it is named in cloud build API.

https://www.merriam-webster.com/dictionary/analogue versus https://www.merriam-webster.com/dictionary/analog. i think it is British English vs American English issue.

None is only selected if analog, digital, frsky is not present.

fair, i only saw loading screen , no FC.

[blckmn]

That is how it is named in cloud build API.

https://www.merriam-webster.com/dictionary/analogue versus https://www.merriam-webster.com/dictionary/analog. i think it is British English vs American English issue.

None is only selected if analog, digital, frsky is not present.

fair, i only saw loading screen , no FC.

I have updated this to be "american". It will flow through in an hour or so.

I does however raise a good point. We should localise these display values. We can do so by adding the american version into the messages.json as a key, and then adding the localisation after request to API. This would allow for crowdin to do the work. However we could also consider adding the localisation to the API based on the language setting provided in the header.