Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] #1479 Wrong image width in containers when nesting containers #1538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Q4U-mspitz
Copy link

Pull Request

Related Issues

Prerequisites

  • [x ] Changes have been tested on TYPO3 v12.4 LTS
  • [x ] Changes have been tested on PHP 8.2

Description

The layout used the colPos of the Contentelement for each Container. If you used a 75/25 container and placed a 50/50 container inside the 75% column, the images are calculated with multiplier 0.75 * 0.75 for the left image and 0.25 * 0.25 for the right image.

Instead of this, the colPos of the container has to be respected in calculation. And that´s what this Fix does.

Steps to Validate

  1. place a 75/25 Container somwhere on the page
  2. place a 50/50 container inside the 75% column of the previous container
  3. place TextMedia-Elements with images inside both columns of the 50/50 container

The right image will be blurry, because the 0.25 multiplier of the outer container is also used for calculating the 50/50 container.

After this fix, both images are calculated the right way and both are the same size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong image width in containers when nesting containers
1 participant