Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring package.json for Better Compatibility and Efficiency #194

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

pplancq
Copy link
Contributor

@pplancq pplancq commented Mar 23, 2024

Hello,

This pull request includes several changes to the package.json file to improve the library's compatibility and efficiency:

  1. Move from jest to peerDependencies: This change allows users of this library to use their own version of Jest, increasing compatibility with different projects.

  2. Move from @types/jest to optionalPeerDependencies: Similar to the above, this allows consumers to optionally use their own TypeScript typings for Jest.

  3. Type libraries moved to devDependencies: This prevents these libraries from being installed by consumers of this library, thus reducing unnecessary installations.

These changes are intended to make this library more efficient and compatible with a wider range of projects.

Please review these changes and provide your feedback.

Best.

@bencompton
Copy link
Owner

Thanks! Some of these ideas I've considered in the past, and I'll have a look at this tonight.

@bencompton bencompton merged commit 3ba24e8 into bencompton:master Mar 23, 2024
2 checks passed
@pplancq pplancq deleted the feature/package branch March 24, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants