Graceful stop in repeat mode - part 1 #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse and validate [Uicommon.repeat] at preference parsing instead of letting the code using the value interpret it freely and possibly error out very late in the process. Restructure the code in text UI to better align with this new preference representation and make it easier to expand in future.
The repeat mode is basically an endless loop. It will run until the process is terminated or a fatal error occurs. Currently the only way for the user to stop repeat mode is to interrupt the process by pressing Ctrl-C or sending a signal that terminates or kills the process. This works but is not satisfactory if the delay between repeated syncs is very short (using fsmonitor on a busy root, for example). The chance of interrupting the process cleanly between syncs becomes very slim. Add a new way to stop repeat mode and do so cleanly. A stop can be requested (in this commit the request method is the signal SIGUSR2) by the user at any time and Unison decides when it is safe to act on that request. Any ongoing sync is allowed to run to completion. This way it is guaranteed that the process terminates between syncs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #833