Display very early errors in GUI #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, errors during very early GUI init process, before the main window was created, would not be displayed in the GUI. The user would not know what was happening because the GUI would just not start. The only way the user would see the error was to read stderr, if available. This patch makes it possible to display very early errors in GUI, as long as GTK init has been successful. If the GTK init itself fails then the user still must have access to stderr to understand what happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, errors during very early GUI init process, before the main window was created, would not be displayed in the GUI. The user would not know what was happening because the GUI would just not start. The only way the user would see the error was to read stderr, if available.
This patch makes it possible to display very early errors in GUI, as long as GTK init has been successful. If the GTK init itself fails then the user still must have access to stderr to understand what happened.