Alternative formulation of orElse and getOrElse #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aankhen
force-pushed
the
alternative-get-or-else
branch
from
dc90e0e
to
fcce712
Compare
Aankhen
force-pushed
the
alternative-get-or-else
branch
from
fcce712
to
939559d
Compare
Aankhen
force-pushed
the
alternative-get-or-else
branch
from
939559d
to
5dd3652
Compare
|
Merry Christmas! Just gonna bump this in case you get the chance to review it… |
|
I added the |
Aankhen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #4
This renames the current
getOrElsetogetOrand adds a newgetOrElsethat takes a function returning a value. In case it helps, this matches Rust’sOption.unwrap_or_elseand Scala’sOption.getOrElse. It is, obviously and unfortunately, a breaking change.If this makes sense, I would like to extend the PR to do the same for the current
orElse, for consistency: it should be renamed toor, andorElseshould be the version that takes a function returning anOption.(I also fixed the duplicated
fourth test.)