Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add HTML semantics #1742

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add HTML semantics #1742

wants to merge 9 commits into from

Conversation

ngunner15
Copy link
Collaborator

@ngunner15 ngunner15 commented Nov 21, 2024 •
edited by github-actions bot
Loading

Description

Closes #1722

Changelog

New

  • WCAG changes to the Login page

Changed

  • Login page

Removed

  • None

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests
  • Used Wave chrome extension

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ngunner15 ngunner15 linked an issue Nov 21, 2024 that may be closed by this pull request
Apply WCAG standards to log in screen #1722
Open
15 tasks
@ngunner15 ngunner15 self-assigned this Nov 21, 2024
@ngunner15 ngunner15 added the front-end front-end related task label Nov 21, 2024
@ngunner15 ngunner15 marked this pull request as ready for review November 21, 2024 23:41
@ngunner15 ngunner15 added this to the WCAG standards milestone Nov 22, 2024
mgaseta
mgaseta approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added only one question.

frontend/src/views/Landing/index.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaseta mgaseta mgaseta approved these changes

@xiaopeng0202 xiaopeng0202 xiaopeng0202 approved these changes

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@ngunner15 ngunner15

Labels
front-end front-end related task
Projects
None yet
Milestone
WCAG standards
Development

Successfully merging this pull request may close these issues.

Apply WCAG standards to log in screen
3 participants
@ngunner15 @xiaopeng0202 @mgaseta