Pdip 1114 mfa polish #2453
kakarlavinodkumarpr-build.yaml
on: pull_request
get-pr-number
7s
Frontend Yarn Lint
1m 17s
PLR Intake Backend Build & Push
38s
WebAPI Backend Build & Push
1m 8s
helm-deployment
4m 0s
Annotations
11 warnings
|
unit-test-backend:
backend/services.plr-intake/Program.cs#L59
The behavior of 'LoggerSinkConfiguration.Console([LogEventLevel],
|
|
unit-test-backend:
backend/services.plr-intake/Program.cs#L71
The behavior of 'LoggerSinkConfiguration.File(string,
|
|
unit-test-backend:
backend/webapi/Infrastructure/Services/PidpAuthorizationService.cs#L38
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
unit-test-backend:
backend/webapi/Infrastructure/Services/PidpAuthorizationService.cs#L44
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
unit-test-backend:
backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Use 'string.IndexOf(char)' instead of 'string.IndexOf(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1866)
|
|
unit-test-backend:
backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
|
|
unit-test-backend:
backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
|
unit-test-backend:
backend/webapi/Features/Discovery/Discovery.cs#L61
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
|
|
unit-test-backend:
backend/webapi/Features/Discovery/Discovery.cs#L61
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
|
unit-test-backend:
backend/webapi/Features/Credentials/Create.cs#L80
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
|
|
Frontend Yarn Lint:
workspace/apps/pidp/src/app/features/shell/components/navbar-menu/nav-menu.ts#L119
Lifecycle interface 'OnDestroy' should be implemented for method 'ngOnDestroy'. (https://angular.io/styleguide#style-09-01)
|