FORMS-1364 CORS for production and localhost #1533
Open
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Release 721022a deployed at https://chefs-dev.apps.silver.devops.gov.bc.ca/pr-1533 |
usingtechnology
requested review from
WalterMoar,
abhilash-aot and
jasonchung1871
WalterMoar
reviewed
Nov 29, 2024
…sed local keycloak" This reverts commit 7addc85.
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
abhilash-aot
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow External API and Map component to work while running in localhost - this requires cors. But we don't want to enable cors for ALL origins, only localhost.
cors is not need in production because we run the compiled UX from the express application - backend and frontend are the same origin.
Type of Change
fix (a bug fix)
Checklist
Further comments