Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide flag to exclude data at compile time #3005

Merged

Conversation

ajwerner
Copy link
Contributor

Fixes #2977

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Let's default this to True to encourage migration :)

rust/settings/BUILD.bazel Outdated Show resolved Hide resolved
@ajwerner ajwerner force-pushed the do_not_include_data_in_compile_data branch 2 times, most recently from a431824 to f1b9eae Compare November 23, 2024 18:22
@ajwerner ajwerner force-pushed the do_not_include_data_in_compile_data branch from f1b9eae to 64034c6 Compare November 23, 2024 18:26
@illicitonion illicitonion added this pull request to the merge queue Nov 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2024
@ajwerner
Copy link
Contributor Author

@illicitonion Thanks for the review. I'm happy with this being default enabled. I fixed the failing tests. Looks like the merge failed due to flakiness downloading bazel:

2024/11/23 18:32:40 could not download Bazel: failed to download bazel: failed to download bazel: could not copy from https://releases.bazel.build/7.3.2/release/bazel-7.3.2-linux-x86_64 to /var/lib/buildkite-agent/.cache/bazelisk/downloads/_tmp/download1571092152: stream error: stream ID 1; INTERNAL_ERROR; received from peer
--
  | Traceback (most recent call last):
  | File "bazelci.py", line 4495, in <module>
  | sys.exit(main())
  | File "bazelci.py", line 4463, in main
  | execute_commands(
  | File "bazelci.py", line 1211, in execute_commands
  | PrepareRepoInCwd(True, initial_setup=True)
  | File "bazelci.py", line 1199, in PrepareRepoInCwd
  | os.environ["OUTPUT_BASE"] = get_output_base(bazel_binary)
  | File "bazelci.py", line 1982, in get_output_base
  | return execute_command_and_get_output(
  | File "bazelci.py", line 2618, in execute_command_and_get_output
  | process = subprocess.run(
  | File "/usr/lib/python3.8/subprocess.py", line 516, in run
  | raise CalledProcessError(retcode, process.args,
  | subprocess.CalledProcessError: Command '['bazel', 'info', 'output_base']' returned non-zero exit status 1.
  ```

@illicitonion illicitonion added this pull request to the merge queue Nov 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2024
@illicitonion illicitonion added this pull request to the merge queue Nov 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2024
@illicitonion illicitonion added this pull request to the merge queue Nov 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2024
@illicitonion illicitonion added this pull request to the merge queue Nov 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2024
@illicitonion illicitonion added this pull request to the merge queue Nov 23, 2024
Merged via the queue into bazelbuild:main with commit e61e6e1 Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make data runtime-only to align with ecosystem norms
2 participants