-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide flag to exclude data at compile time #3005
Merged
illicitonion
merged 2 commits into
bazelbuild:main
from
ajwerner:do_not_include_data_in_compile_data
Nov 23, 2024
Merged
provide flag to exclude data at compile time #3005
illicitonion
merged 2 commits into
bazelbuild:main
from
ajwerner:do_not_include_data_in_compile_data
Nov 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2024
ajwerner
force-pushed
the
do_not_include_data_in_compile_data
branch
2 times, most recently
from
November 18, 2024 14:04
5e1b21f
to
5e7e310
Compare
illicitonion
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Let's default this to True
to encourage migration :)
ajwerner
force-pushed
the
do_not_include_data_in_compile_data
branch
2 times, most recently
from
November 23, 2024 18:22
a431824
to
f1b9eae
Compare
ajwerner
force-pushed
the
do_not_include_data_in_compile_data
branch
from
November 23, 2024 18:26
f1b9eae
to
64034c6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 23, 2024
@illicitonion Thanks for the review. I'm happy with this being default enabled. I fixed the failing tests. Looks like the merge failed due to flakiness downloading bazel:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2977