-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy: make Cc/Rust toolchains optional #2766
base: main
Are you sure you want to change the base?
clippy: make Cc/Rust toolchains optional #2766
Conversation
In certain situations (cross compilation with `go`) we might not have Cc/Rust toolchains that are available for the transitioned to execution/target platform. For the linting case with `clippy` it is acceptable to just skip these targets. See: https://github.com/lummax/rules_rust_clippy_go_cross_reproducer
Looks good! Could you update this resolving the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example confuses me. Do you have any toolchains registered at all? Doesn't clippy use of the --sysroot
flag and require a valid sysroot?
|
In certain situations (cross compilation with
go
) we might not have Cc/Rust toolchains that are available for the transitioned to execution/target platform.For the linting case with
clippy
it is acceptable to just skip these targets.See: https://github.com/lummax/rules_rust_clippy_go_cross_reproducer