Make calendar integration optional #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dppdppd
changed the title
bastibe
reviewed
Jan 23, 2022
org-journal.el
Outdated
| (add-hook 'calendar-today-visible-hook 'org-journal-mark-entries) | ||
| ;;;###autoload | ||
| (add-hook 'calendar-today-invisible-hook 'org-journal-mark-entries) | ||
| (if org-journal-enable-calendar-integration |
There was a problem hiding this comment.
I think this breaks the autoloads, which are necessary for making org-journal work in the calendar if it hasn't been invoked yet. So the branch probably needs to happen inside org-journal-mark-entries instead.
bastibe
reviewed
Jan 23, 2022
org-journal.el
Outdated
| (define-key calendar-mode-map (kbd "j s y") 'org-journal-search-calendar-year))) | ||
| do (define-key org-journal-mode-map (funcall key-func org-journal-prefix-key key) command)))) | ||
|
|
||
| (if org-journal-enable-calendar-integration |
There was a problem hiding this comment.
Would it break anything if these remained enabled? Or perhaps it would make sense to only disable the first five. I could see a use case for org-journal-new-date-entry and the org-journal-search-* functions even with the calendar highlights disabled.
|
Something like this will work. Thank you! But I added two comments that we should discuss or fix. |
xeruf
approved these changes
Sep 26, 2022
|
Fixes #375 |
casch-at
changed the title
casch-at
changed the title
casch-at
changed the title
|
@dppdppd Is it ok if I push to this branch, and do a squash merge afterwards? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
something like this?