Create insert journal headline at point

[dalanicolai]

I have a project where I would like to use journal style headlines outside a journal file. This small adjustment enables the option to insert journal style headlines at point. I thought it might be useful sometimes for other user too. If you think the extra command is too "exclusive" to be added by default then it is no problem if you remove it. But then it would still be nice to keep the optional insert-at-point argument.

[bastibe]

I like it! Let's see what @cslux will say.

[bastibe]

On a second thought, and a more thorough look at your code, I feel that this behavior does not fit well into org-journal. Reading through org-journal's code, it is not clear how this functionality is related to org-journal's behavior.

I think I would advise you to maintain a fork or a derivative project for this functionality.

That said, I would have no problem with adding an optional argument or configuration variable here and there for enabling your fork.

[dalanicolai]

Okay thanks, that is fine also. On the other hand, all arguments I've added are optional, and should not break anything.

The only parts that could break something would be

• moving the TODO in front of the time in the headline (in Improve new scheduled entry command #338), but as I wrote in that PR (with a link to org's documentation), that is required for org to handle the HEADLINE as a todo. For example, the current TODO headlines created with org-journal-new-scheduled-entry don't show up in org-todo-list.
• adding the time within the time-stamp (but that was merged already by cslux, he (or me) just had to update a single test)
• inserting the scheduled keyword when creating a scheduled entry

I would say these are nice little "improvements/corrections" (if indeed they do not break the functionality), but they are not essential at all of course. Anyway, no problem for me to maintain a fork.

[bastibe]

I saw that all the arguments are optional. My concern is more with the maintenance surface. Optional arguments only make sense if the code itself is actually using them--otherwise, how would you decide whether to delete some apparently unused piece of code?

Therefore, such affordances for third parties must be kept to a minimum, and rigorously documented (and tested, if possible). In case of the insert-at-point arguments, I felt that they needed to be introduced in a few too many places for comfort. Perhaps there is a way of refactoring org-journal's internals such that insertion and location are handled separately, and can be reused by your code more easily (just thinking out loud here). That would be a preferred solution to me.

As for the order of date and TODO, as well as the scheduled keyword, I am all in favor of your fixes in those instances.

All of that said, I am not really the maintainer of org-journal any longer. If @cslux later decides that this pull request is acceptable after all, I am entirely ok with that, too.