Fix a compatibility issue introduced in Sphinx 7.2.0 and later that changes path handling to Pathlib #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges path handling to Pathlib
|
TGTM. Will commit after the run and do a quick release. |
|
Thanks. There was another bug in the site docs that needed to be fixed to get the CI to run. |
|
@bashtage Perfect, thank you for the quick fix/release :) |
|
@bashtage I must caution a little tho. We only struck this error, and my PR only solved the issue we faced. I can't say for sure as we have not looked through the entire code base for all uses of this changed variable or the other ones that they changed out in the PR from sphinx. There might be more issues that we did not reached yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137