Long-awaited rewrite to pyparsing and AST #8

knopki · 2023-11-21T03:29:28Z

⏳

serialization and back

tests: dependency injection via mixin for testability fix(fallback node): match only one word feat: fallback on parse fail on any node feat: root node

fix: correct working of recursive types fix: no more recursion errors tests: almost full coverage

pep8speaks · 2023-11-21T03:29:41Z

Hello @knopki! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pytopas/ast.py:

Line 218:80: E501 line too long (86 > 79 characters)
Line 224:80: E501 line too long (83 > 79 characters)
Line 258:80: E501 line too long (87 > 79 characters)
Line 271:30: E203 whitespace before ':'
Line 387:80: E501 line too long (86 > 79 characters)
Line 388:80: E501 line too long (86 > 79 characters)
Line 389:80: E501 line too long (83 > 79 characters)
Line 448:80: E501 line too long (86 > 79 characters)
Line 457:80: E501 line too long (84 > 79 characters)
Line 461:80: E501 line too long (87 > 79 characters)
Line 509:80: E501 line too long (82 > 79 characters)
Line 527:80: E501 line too long (81 > 79 characters)
Line 617:80: E501 line too long (86 > 79 characters)
Line 678:80: E501 line too long (81 > 79 characters)
Line 709:80: E501 line too long (85 > 79 characters)
Line 1057:80: E501 line too long (88 > 79 characters)
Line 1080:80: E501 line too long (80 > 79 characters)
Line 1125:80: E501 line too long (80 > 79 characters)
Line 1142:80: E501 line too long (84 > 79 characters)

In the file pytopas/grammar.py:

Line 64:80: E501 line too long (83 > 79 characters)
Line 79:80: E501 line too long (88 > 79 characters)
Line 100:80: E501 line too long (80 > 79 characters)
Line 101:80: E501 line too long (82 > 79 characters)
Line 106:80: E501 line too long (86 > 79 characters)
Line 114:80: E501 line too long (86 > 79 characters)
Line 115:80: E501 line too long (86 > 79 characters)
Line 121:80: E501 line too long (83 > 79 characters)
Line 133:80: E501 line too long (80 > 79 characters)
Line 138:80: E501 line too long (87 > 79 characters)
Line 139:80: E501 line too long (87 > 79 characters)
Line 144:80: E501 line too long (82 > 79 characters)
Line 149:80: E501 line too long (82 > 79 characters)
Line 156:80: E501 line too long (83 > 79 characters)
Line 161:80: E501 line too long (82 > 79 characters)
Line 200:80: E501 line too long (80 > 79 characters)
Line 222:80: E501 line too long (85 > 79 characters)
Line 241:80: E501 line too long (90 > 79 characters)
Line 250:80: E501 line too long (89 > 79 characters)

In the file tests/test_ast.py:

Line 146:80: E501 line too long (82 > 79 characters)
Line 161:80: E501 line too long (82 > 79 characters)
Line 164:80: E501 line too long (82 > 79 characters)
Line 179:80: E501 line too long (82 > 79 characters)
Line 195:80: E501 line too long (80 > 79 characters)
Line 220:80: E501 line too long (87 > 79 characters)
Line 271:80: E501 line too long (84 > 79 characters)
Line 292:80: E501 line too long (80 > 79 characters)
Line 551:80: E501 line too long (85 > 79 characters)
Line 565:80: E501 line too long (80 > 79 characters)
Line 640:80: E501 line too long (86 > 79 characters)

In the file tests/test_cli_json2topas.py:

Line 34:80: E501 line too long (82 > 79 characters)

In the file tests/test_cli_topas2json.py:

Line 30:80: E501 line too long (88 > 79 characters)

In the file tests/test_grammar.py:

Line 43:80: E501 line too long (87 > 79 characters)
Line 44:80: E501 line too long (82 > 79 characters)
Line 127:80: E501 line too long (88 > 79 characters)
Line 129:80: E501 line too long (83 > 79 characters)
Line 146:80: E501 line too long (83 > 79 characters)
Line 149:80: E501 line too long (83 > 79 characters)
Line 163:80: E501 line too long (80 > 79 characters)
Line 359:80: E501 line too long (82 > 79 characters)
Line 402:80: E501 line too long (85 > 79 characters)
Line 435:80: E501 line too long (81 > 79 characters)
Line 454:80: E501 line too long (87 > 79 characters)
Line 555:80: E501 line too long (81 > 79 characters)
Line 638:80: E501 line too long (87 > 79 characters)
Line 639:80: E501 line too long (85 > 79 characters)
Line 643:80: E501 line too long (87 > 79 characters)
Line 705:80: E501 line too long (88 > 79 characters)
Line 711:80: E501 line too long (86 > 79 characters)
Line 795:80: E501 line too long (81 > 79 characters)

In the file tests/test_parser.py:

Line 9:80: E501 line too long (87 > 79 characters)

Comment last updated at 2023-12-19 12:35:10 UTC

blokhin · 2023-11-21T13:10:58Z

@knopki cool 💪💪 looking forward to it!

knopki added 20 commits November 21, 2023 06:23

test: more tests

ad3a3a6

fix(parser): arithmetic operator

c5ded6a

feat(parser): initial pyparsing

0ef5672

feat: infix notation formula with convertion between source, ast,

7a3aaee

serialization and back

fix(tests): imports

343d8cb

fix(FallbackNode): match any non space

43797bd

fix(FormulaOps): match first

ac08c92

chore: remove litter

cd0a715

feat(RootNode): implement root

910c013

feat: many features

c570ccc

tests: dependency injection via mixin for testability fix(fallback node): match only one word feat: fallback on parse fail on any node feat: root node

feat(cli): implement cli tools

d3bcc6b

chore: remove lark stuff

a94cdf8

feat(FallbackNode): cut text

fa2b572

feat: save line breaks

cf8ca24

feat: ignore comments

79b147c

fix: parse all

8aea1c9

feat(cli): ignore warnings

068932b

feat: print_dump diagnostic helper

e924e43

feat: full rewrite

57f9c20

fix: correct working of recursive types fix: no more recursion errors tests: almost full coverage

docs(README.md): update

5f3ff35

knopki self-assigned this Nov 21, 2023

fix(ast.py): Self import error when python < 3.11

2b1af57

blokhin added enhancement New feature or request help wanted Extra attention is needed python Pull requests that update Python code labels Nov 21, 2023

knopki added 3 commits December 1, 2023 23:59

fix(grammar): root node + add tests

b403553

style: apply linter hints

e2784d7

feat(TextNode): text node instead of fallback node

fd7b69f

knopki added 20 commits December 19, 2023 14:38

fix(grammar): use decimals

5624f59

test(grammar): decimals

5db11be

feat(grammar,ast): local node

3768aa6

feat(grammar,ast): existing_prm node

6f7b5fb

feat(grammar,ast): num_runs node

25cd77c

feat(grammar,ast): xdd node

7489c97

feat(grammar,ast): axial_conv node

b2252f1

refactor(tests): split tests

d53145e

refactor(tests): split tests

5db39e8

test: 100% coverage

b20213d

fix(ast,tests): root node multiline fix

06c2e65

fix(grammar,ast,tests): num_runs argument type added

44ade8b

feat(grammar,ast,tests): macro node

edeeb94

feat(grammar,ast,tests): bkg node

a197ec4

feat(grammar,ast,tests): scale node

711046c

refactor: remove litter

2ccdacb

style: fix lint errors

d5d26a9

refactor: backport to 3.8

e1f95fc

ci: fix linters

32dfc9a

ci: fix linters

a23d3de

knopki marked this pull request as ready for review April 11, 2024 17:06

blokhin approved these changes Apr 15, 2024

View reviewed changes

blokhin merged commit e15670e into basf:master Apr 15, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Long-awaited rewrite to pyparsing and AST #8

Long-awaited rewrite to pyparsing and AST #8

knopki commented Nov 21, 2023

pep8speaks commented Nov 21, 2023 •

edited

Loading

blokhin commented Nov 21, 2023

Long-awaited rewrite to pyparsing and AST #8

Long-awaited rewrite to pyparsing and AST #8

Conversation

knopki commented Nov 21, 2023

pep8speaks commented Nov 21, 2023 • edited Loading

Comment last updated at 2023-12-19 12:35:10 UTC

blokhin commented Nov 21, 2023

pep8speaks commented Nov 21, 2023 •

edited

Loading