Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone parser with to json and back converters #4

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

knopki
Copy link
Contributor

@knopki knopki commented Sep 16, 2023

  • Setup project
  • Standalone lark parser
  • Rudimentary topas-to-json and json-to-topas converters with CLI tools
  • Tests

@knopki knopki requested a review from blokhin September 16, 2023 22:10
@knopki knopki self-assigned this Sep 16, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this project seems to be down 😞

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knopki wow, this is so C++ 😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knopki why a standalone version is used, rather than an installable library?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w.r.t.

Regenerate standalone lark parser after grammar.lark change: make parser

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knopki why a standalone version is used, rather than an installable library?

Compiling a grammar is about 5 seconds. If you use lark as a library, you'll either have to make the user suffer (compile to cache on the first run) or ship the cache with the package. When using the standalone version, almost the entire file is the result of compiling the grammar.
And the lack of runtime dependencies is more of a positive feature.

@blokhin blokhin merged commit fe8e0de into basf:master Sep 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants