Skip to content

Commit

Permalink
Fix/hero exp (#672)
Browse files Browse the repository at this point in the history
* fixed typo

* refactored isReady to be true after experiment initialization, regardless of success
  • Loading branch information
brendan-defi authored Jul 24, 2024
1 parent 966e56b commit 13a5637
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion apps/base-docs/src/components/Hero/ControlHero/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default function ControlHero() {
<header className={styles.heroContainer}>
<div className="layout-container">
<div className={styles.heroTextContainer}>
<h1 className={styles.heroText}>Everything you need to build onchian</h1>
<h1 className={styles.heroText}>Everything you need to build onchain</h1>
</div>
<HeroButton />
</div>
Expand Down
3 changes: 2 additions & 1 deletion libs/base-ui/contexts/Experiments.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@ export default function ExperimentsProvider({ children }: ExperimentsProviderPro
async function startExperiments() {
try {
await experimentClient.start();
setIsReady(true);
} catch (exception) {
console.log(`Error starting experiments for ${ampDeploymentKey}:`, exception);
} finally {
setIsReady(true);
}
}
void startExperiments();
Expand Down

0 comments on commit 13a5637

Please sign in to comment.