Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use aws sdk v2 and update dependencies #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndreZiviani
Copy link

@AndreZiviani AndreZiviani commented Jan 13, 2022

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? yes
License Apache 2.0

What's in this PR?

Update AWS SDK to version 2
Update all dependencies

Why?

IRSA was not working for me, also everything was pretty old

Additional context

The AWS SDK v2 does not expose the partitions feature, I believe it should work out of the box but I haven't tested, removed it from README as well

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)

@eric-engberg
Copy link

Is this project dead? I don't see another exporter out there that does this.. Can this get updated and merged?

@AndreZiviani
Copy link
Author

@eric-engberg I think so, I've forked this and added some functionalities that I wanted
https://github.com/AndreZiviani/eks-cost-exporter
https://github.com/AndreZiviani/helm-charts/tree/main/charts/eks-cost-exporter

I know it crashes sometimes but I haven't had the time to fix it, feel free to try it

@eric-engberg
Copy link

Oh nice. Thanks.. was playing around with the source for the PR here but this works too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants