Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: introduce clang-format in the code base, enforce via CI #4

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

build: introduce clang-format in the code base, enforce via CI #4

wants to merge 5 commits into from

Commits on Sep 29, 2023

  1. build: introduce clang-format in the code base, enforce via CI 

    Individual developers should execute "make reformat-code" or equivalent at each
commit; they can use a pre-commit hook if they want.

The commit also adds a CI workflow that verifies that the tip of a PR (or of
main) respects the clang-format rules.
    muxator committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2d9e416 View commit details
    Browse the repository at this point in the history

  2. docker: check code formatting before building the images

    muxator committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8e7313f View commit details
    Browse the repository at this point in the history

  3. test: clang-format 15 would break around this line. Let's preemptivle… 

    …y disable it
    muxator committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9e69804 View commit details
    Browse the repository at this point in the history

  4. itcoin-fbft: apply clang-format rules to the code base

    muxator committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e06eecb View commit details
    Browse the repository at this point in the history

  5. format: selectively enable InsertBraces 

    This change has been done individually in order to manually inspect it, as
advised by https://clang.llvm.org/docs/ClangFormatStyleOptions.html#insertbraces:
    Setting this option to true could lead to incorrect code formatting due to
    clang-format’s lack of complete semantic information. As such, extra care
    should be taken to review code changes made by this option.
    muxator committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2694ebc View commit details
    Browse the repository at this point in the history