Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2201.9.x] Fix getting non-accessible symbol error for error intersections with details #42925

Merged
merged 5 commits into from
Jul 1, 2024
Merged

[2201.9.x] Fix getting non-accessible symbol error for error intersections with details #42925

merged 5 commits into from
Jul 1, 2024

Conversation

dulajdilshan
Copy link
Contributor

@dulajdilshan dulajdilshan commented Jun 14, 2024 •
edited
Loading

Purpose

$title

Fixes #42806

PR for master: #42876

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@dulajdilshan dulajdilshan added Area/Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Jun 14, 2024
@dulajdilshan dulajdilshan added this to the 2201.9.1 milestone Jun 14, 2024
chiranSachintha
chiranSachintha previously approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@chiranSachintha chiranSachintha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added minor comments in the PR sent to the master branch. Since this is urgent for the 9.1 release, we can fix them in a separate PR.

@mindula mindula modified the milestones: 2201.9.1, 2201.9.2 Jun 17, 2024
MaryamZi
MaryamZi reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@MaryamZi MaryamZi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dulajdilshan, please update this PR similar to the PR to master.

@dulajdilshan
Copy link
Contributor Author

dulajdilshan commented Jul 1, 2024 •
edited
Loading

@dulajdilshan, please update this PR similar to the PR to master.

Yeah sure. Closed accidentally while resolving a merge conflict

@dulajdilshan dulajdilshan reopened this Jul 1, 2024
@dulajdilshan dulajdilshan linked an issue Jul 1, 2024 that may be closed by this pull request
[Bug]: Getting non-accessible symbol error for error intersections with details #42806
Closed
@dulajdilshan dulajdilshan merged commit 61b2404 into ballerina-platform:2201.9.x Jul 1, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryamZi MaryamZi MaryamZi approved these changes

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

@chiranSachintha chiranSachintha Awaiting requested review from chiranSachintha

@hevayo hevayo Awaiting requested review from hevayo

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha

@mohanvive mohanvive Awaiting requested review from mohanvive

Assignees
No one assigned
Labels
Area/Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
2201.9.2
Development

Successfully merging this pull request may close these issues.

[Bug]: Getting non-accessible symbol error for error intersections with details
4 participants
@dulajdilshan @MaryamZi @chiranSachintha @mindula