Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bindgen tool tests with java 11 dependencies #41249

Merged

Conversation

warunalakshitha
Copy link
Contributor

Purpose

Fixes #41226

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@warunalakshitha warunalakshitha added this to the 2201.8.0 milestone Aug 20, 2023
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 79.59% and no project coverage change.

Comparison is base (5965e35) 76.34% compared to head (275346b) 76.34%.
Report is 63 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master   #41249    +/-   ##
==========================================
  Coverage     76.34%   76.34%            
- Complexity    52351    52395    +44     
==========================================
  Files          2868     2868            
  Lines        197879   197981   +102     
  Branches      25720    25757    +37     
==========================================
+ Hits         151062   151146    +84     
- Misses        38494    38498     +4     
- Partials       8323     8337    +14     
Files Changed Coverage Δ
...ler/api/symbols/resourcepath/util/PathSegment.java 100.00% <ø> (ø)
...rg/ballerinalang/langserver/rename/RenameUtil.java 81.70% <0.00%> (-1.49%) ⬇️
...api/impl/symbols/BallerinaPathParameterSymbol.java 69.09% <65.00%> (+17.87%) ⬆️
...o/ballerina/compiler/api/impl/ReferenceFinder.java 83.33% <65.21%> (-0.67%) ⬇️
...llerinalang/bindgen/command/BindingsGenerator.java 81.97% <65.78%> (-2.13%) ⬇️
...allerinalang/bindgen/utils/BindgenMvnResolver.java 67.85% <75.00%> (+0.35%) ⬆️
.../io/ballerina/compiler/api/impl/SymbolFactory.java 90.82% <81.81%> (+0.11%) ⬆️
...pi/impl/symbols/BallerinaResourceMethodSymbol.java 85.41% <87.50%> (+0.63%) ⬆️
...a/io/ballerina/compiler/api/impl/SymbolFinder.java 72.89% <96.00%> (+0.83%) ⬆️
...llerina/cli/task/ResolveMavenDependenciesTask.java 38.46% <100.00%> (+2.61%) ⬆️
... and 9 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Nadeeshan96 Nadeeshan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 6d331d4 into ballerina-platform:master Aug 20, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bindgen toml update fail if we have java 11 dependencies
2 participants