Merge pull request #42896 from Shadow-Devil/replaceall-to-replace

Use `replace` instead of `replaceAll` if no regex is needed

ballerina-shell/modules/shell-cli/src/main/java/io/ballerina/shell/cli/handlers/HelpCommand.java

@@ -73,8 +73,8 @@ public void run(String... args) {
             } else {
                 try {
                     ballerinaShell.outputInfo(NEW_LINE + bbeHelpProvider.getDescription(topic)
-                            .replaceAll(TAGS, EMPTY_STRING));
-                    ballerinaShell.outputInfo(URL_PREFIX + URL + topic.replaceAll(" ", "-"));
+                            .replace(TAGS, EMPTY_STRING));
+                    ballerinaShell.outputInfo(URL_PREFIX + URL + topic.replace(" ", "-"));
 
                 } catch (HelpProviderException e) {
                     ballerinaShell.outputError(NEW_LINE + "Can not find the topic : " + topic  + NEW_LINE + NEW_LINE +

ballerina-shell/modules/shell-cli/src/main/java/io/ballerina/shell/cli/handlers/help/BbeTopicsProvider.java

@@ -66,7 +66,7 @@ private void populateTopicList() {
                     Stream<BbeRecord> sampleList = Arrays.stream(samples);
                     sampleList.forEach((bbeRecordElement) -> {
                         if (bbeRecordElement != null) {
-                            topicList.add(bbeRecordElement.getUrl().replaceAll("-", " "));
+                            topicList.add(bbeRecordElement.getUrl().replace("-", " "));
                         }
                     });
                 }

ballerina-shell/modules/shell-core/src/main/java/io/ballerina/shell/utils/StringUtils.java

@@ -62,7 +62,7 @@ public static String quoted(String identifier) {
      */
     public static String shortenedString(Object input) {
         String value = String.valueOf(input);
-        value = value.replaceAll("\n", "");
+        value = value.replace("\n", "");
         if (value.length() > MAX_VAR_STRING_LENGTH) {
             int subStrLength = MAX_VAR_STRING_LENGTH / 2;
             return value.substring(0, subStrLength)

bvm/ballerina-profiler/src/main/java/io/ballerina/runtime/profiler/runtime/StackTraceMap.java

@@ -62,6 +62,6 @@ static String getCallStackString(String stackKey) {
     }
 
     private static String decodeStackElement(String stackElement) {
-        return Utils.decodeIdentifier(stackElement.replaceAll("\\$value\\$", ""));
+        return Utils.decodeIdentifier(stackElement.replace("$value$", ""));
     }
 }

cli/ballerina-cli/src/main/java/io/ballerina/cli/cmd/CommandUtil.java

@@ -954,9 +954,9 @@ public static void initPackage(Path path, String packageName) throws IOException
         String defaultManifest = FileUtils.readFileAsString(NEW_CMD_DEFAULTS + "/" + "manifest-app.toml");
         // replace manifest distribution with a guessed value
         defaultManifest = defaultManifest
-                .replaceAll(ORG_NAME, ProjectUtils.guessOrgName())
-                .replaceAll(PKG_NAME, guessPkgName(packageName, "app"))
-                .replaceAll(DIST_VERSION, RepoUtils.getBallerinaShortVersion());
+                .replace(ORG_NAME, ProjectUtils.guessOrgName())
+                .replace(PKG_NAME, guessPkgName(packageName, "app"))
+                .replace(DIST_VERSION, RepoUtils.getBallerinaShortVersion());
         Files.write(ballerinaToml, defaultManifest.getBytes(StandardCharsets.UTF_8));
     }
 
@@ -966,9 +966,9 @@ private static void initLibPackage(Path path, String packageName) throws IOExcep
 
         String defaultManifest = FileUtils.readFileAsString(NEW_CMD_DEFAULTS + "/" + "manifest-lib.toml");
         // replace manifest org and name with a guessed value.
-        defaultManifest = defaultManifest.replaceAll(ORG_NAME, ProjectUtils.guessOrgName())
-                .replaceAll(PKG_NAME, guessPkgName(packageName, "lib"))
-                .replaceAll(DIST_VERSION, RepoUtils.getBallerinaShortVersion());
+        defaultManifest = defaultManifest.replace(ORG_NAME, ProjectUtils.guessOrgName())
+                .replace(PKG_NAME, guessPkgName(packageName, "lib"))
+                .replace(DIST_VERSION, RepoUtils.getBallerinaShortVersion());
 
         write(ballerinaToml, defaultManifest.getBytes(StandardCharsets.UTF_8));
 
@@ -990,16 +990,16 @@ private static void initToolPackage(Path path, String packageName) throws IOExce
 
         String defaultManifest = FileUtils.readFileAsString(NEW_CMD_DEFAULTS + "/" + "manifest-app.toml");
         defaultManifest = defaultManifest
-                .replaceAll(ORG_NAME, ProjectUtils.guessOrgName())
-                .replaceAll(PKG_NAME, guessPkgName(packageName, TOOL_DIR))
-                .replaceAll(DIST_VERSION, RepoUtils.getBallerinaShortVersion());
+                .replace(ORG_NAME, ProjectUtils.guessOrgName())
+                .replace(PKG_NAME, guessPkgName(packageName, TOOL_DIR))
+                .replace(DIST_VERSION, RepoUtils.getBallerinaShortVersion());
         Files.write(ballerinaToml, defaultManifest.getBytes(StandardCharsets.UTF_8));
 
         Path balToolToml = path.resolve(ProjectConstants.BAL_TOOL_TOML);
         Files.createFile(balToolToml);
 
         String balToolManifest = FileUtils.readFileAsString(NEW_CMD_DEFAULTS + "/" + "manifest-tool.toml");
-        balToolManifest = balToolManifest.replaceAll(TOOL_ID, guessPkgName(packageName, TOOL_DIR));
+        balToolManifest = balToolManifest.replace(TOOL_ID, guessPkgName(packageName, TOOL_DIR));
 
         write(balToolToml, balToolManifest.getBytes(StandardCharsets.UTF_8));
     }

cli/ballerina-cli/src/main/java/io/ballerina/cli/cmd/PushCommand.java

@@ -515,7 +515,7 @@ private void pushBalaToRemote(Path balaPath, CentralAPIClient client) {
                         errorMessage = errorMessage.substring(0, errorMessage.indexOf("\n\tat"));
                     }
 
-                    errorMessage = errorMessage.replaceAll("error: ", "");
+                    errorMessage = errorMessage.replace("error: ", "");
 
                     // when unauthorized access token for organization is given
                     if (errorMessage.contains("subject claims missing in the user info repsonse")) {

cli/ballerina-cli/src/main/java/io/ballerina/cli/utils/NativeUtils.java

@@ -303,7 +303,7 @@ private static void extractMockFunctionClassMapping(Map<String, TestSuite> testS
                         functionToMock = key.substring(key.indexOf(MOCK_LEGACY_DELIMITER) + 1);
                     }
                 }
-                functionToMock = functionToMock.replaceAll("\\\\", "");
+                functionToMock = functionToMock.replace("\\", "");
                 mockFunctionClassMapping.computeIfAbsent(functionToMockClassName,
                         k -> new ArrayList<>()).add("$ORIG_" + functionToMock);
             }
@@ -444,7 +444,7 @@ private static void dumpJar(Map<String, byte[]> modifiedClassDefs, Map<String, b
             for (Map.Entry<String, byte[]> modifiedClassDef : modifiedClassDefs.entrySet()) {
                 if (modifiedClassDef.getValue().length > 0) {
                     String entry = modifiedClassDef.getKey();
-                    String path = entry.replaceAll("\\.", PATH_SEPARATOR) + CLASS_EXTENSION;
+                    String path = entry.replace(".", PATH_SEPARATOR) + CLASS_EXTENSION;
                     duplicatePaths.add(path);
                     jarOutputStream.putNextEntry(new ZipEntry(path));
                     jarOutputStream.write(modifiedClassDefs.get(entry));
@@ -502,7 +502,7 @@ private static void populateClassNameVsFunctionToMockMap(Map<String, List<String
                     functionToMock = key.substring(key.indexOf(MOCK_LEGACY_DELIMITER));
                 }
             }
-            functionToMock = functionToMock.replaceAll("\\\\", "");
+            functionToMock = functionToMock.replace("\\", "");
             classVsMockFunctionsMap.computeIfAbsent(functionToMockClassName,
                     k -> new ArrayList<>()).add(functionToMock);
         }

cli/ballerina-cli/src/main/java/io/ballerina/cli/utils/TestUtils.java

@@ -180,7 +180,7 @@ public static void generateTesterinaReports(Project project, TestReport testRepo
         testReport.finalizeTestResults(project.buildOptions().codeCoverage());
 
         Gson gson = new Gson();
-        String json = gson.toJson(testReport).replaceAll("\\\\\\(", "(");
+        String json = gson.toJson(testReport).replace("\\(", "(");
 
         File jsonFile = new File(reportDir.resolve(RESULTS_JSON_FILE).toString());
         try (FileOutputStream fileOutputStream = new FileOutputStream(jsonFile)) {

compiler/ballerina-lang/src/main/java/io/ballerina/projects/util/ProjectUtils.java

@@ -388,7 +388,7 @@ public static String guessPkgName(String packageName, String template) {
 
         // if package name has consecutive underscores, replace them with a single underscore
         if (packageName.contains("__")) {
-            packageName = packageName.replaceAll("__", "_");
+            packageName = packageName.replace("__", "_");
         }
 
         // if package name has trailing underscore remove it

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/ClosureGenerator.java

@@ -759,7 +759,7 @@ private String generateName(String name, BLangNode parent) {
             case CLASS_DEFN:
                 return generateName(((BLangClassDefinition) parent).name.getValue() + UNDERSCORE + name, parent.parent);
             case FUNCTION:
-                name = ((BLangFunction) parent).symbol.name.value.replaceAll("\\.", UNDERSCORE) + UNDERSCORE + name;
+                name = ((BLangFunction) parent).symbol.name.value.replace(".", UNDERSCORE) + UNDERSCORE + name;
                 return generateName(name, parent.parent);
             case RESOURCE_FUNC:
                 return generateName(((BLangResourceFunction) parent).name.value + UNDERSCORE + name, parent.parent);

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/BLangMarkdownDocumentation.java

@@ -107,7 +107,7 @@ public BLangMarkDownDeprecatedParametersDocumentation getDeprecatedParametersDoc
     public String getDocumentation() {
         return documentationLines.stream()
                 .map(BLangMarkdownDocumentationLine::getText)
-                .collect(Collectors.joining("\n")).replaceAll("\r", "");
+                .collect(Collectors.joining("\n")).replace("\r", "");
     }
 
     @Override

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangMarkDownDeprecationDocumentation.java

@@ -60,7 +60,7 @@ public void addDeprecationLine(String text) {
 
     @Override
     public String getDocumentation() {
-        return String.join("\n", this.deprecationDocumentationLines).replaceAll("\r", "");
+        return String.join("\n", this.deprecationDocumentationLines).replace("\r", "");
     }
 
     @Override

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangMarkdownParameterDocumentation.java

@@ -56,7 +56,7 @@ public void addParameterDocumentationLine(String text) {
 
     @Override
     public String getParameterDocumentation() {
-        return parameterDocumentationLines.stream().collect(Collectors.joining("\n")).replaceAll("\r", "");
+        return parameterDocumentationLines.stream().collect(Collectors.joining("\n")).replace("\r", "");
     }
 
     @Override

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangMarkdownReturnParameterDocumentation.java

@@ -59,7 +59,7 @@ public void addReturnParameterDocumentationLine(String text) {
 
     @Override
     public String getReturnParameterDocumentation() {
-        return returnParameterDocumentationLines.stream().collect(Collectors.joining("\n")).replaceAll("\r", "");
+        return returnParameterDocumentationLines.stream().collect(Collectors.joining("\n")).replace("\r", "");
     }
 
     @Override

language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/common/utils/CommonUtil.java

@@ -269,7 +269,7 @@ public static boolean isLangLibOrLangTest(ModuleID moduleID) {
      * @return The identifier with escape characters escaped
      */
     public static String escapeEscapeCharsInIdentifier(String identifier) {
-        return identifier.replaceAll("\\\\", "\\\\\\\\");
+        return identifier.replace("\\", "\\\\");
     }
 
     /**
@@ -279,8 +279,8 @@ public static String escapeEscapeCharsInIdentifier(String identifier) {
      * @return Processed text
      */
     public static String escapeSpecialCharsInInsertText(String text) {
-        return text.replaceAll("\\\\", "\\\\\\\\")
-                .replaceAll("\\$", Matcher.quoteReplacement("\\$"));
+        return text.replace("\\", "\\\\")
+                .replace("$", "\\$");
     }
 
     /**

language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/telemetry/LSTelemetryEvent.java

@@ -46,7 +46,7 @@ protected static String getComponentName(LSOperation operation) {
         if (operation == null) {
             return LS_TELEMETRY_COMPONENT_NAME;
         }
-        return LS_TELEMETRY_COMPONENT_NAME + "." + operation.getName().replaceAll("/", "_");
+        return LS_TELEMETRY_COMPONENT_NAME + "." + operation.getName().replace("/", "_");
     }
 
     public String getComponent() {

misc/ballerinalang-data-mapper/src/main/java/org/ballerinalang/datamapper/AIDataMapperCodeActionUtil.java

@@ -789,9 +789,9 @@ private String generateMappingFunction(String mappingFromServer, String foundTyp
             rightType = rhsSignature;
         }
 
-        mappingFromServer = mappingFromServer.replaceAll("\"", "");
-        mappingFromServer = mappingFromServer.replaceAll(",", ", ");
-        mappingFromServer = mappingFromServer.replaceAll(":", ": ");
+        mappingFromServer = mappingFromServer.replace("\"", "");
+        mappingFromServer = mappingFromServer.replace(",", ", ");
+        mappingFromServer = mappingFromServer.replace(":", ": ");
 
 
         // change the generated mapping function to be compatible with spread fields.

misc/ballerinalang-data-mapper/src/main/java/org/ballerinalang/datamapper/DataMapperNodeVisitor.java

@@ -95,7 +95,7 @@ public void visit(VariableDeclarationNode variableDeclarationNode) {
                     SpecificFieldNode specificFieldNode = (SpecificFieldNode) field;
                     if (specificFieldNode.fieldName().kind() == SyntaxKind.STRING_LITERAL) {
                         String fieldName = ((BasicLiteralNode) specificFieldNode.fieldName()).literalToken().text();
-                        fieldName = fieldName.replaceAll("\"", "");
+                        fieldName = fieldName.replace("\"", "");
                         Optional<Symbol> symbol = this.model.symbol(variableDeclarationNode);
                         if (symbol.isPresent()) {
                             TypeSymbol typeSymbol = ((VariableSymbol) symbol.get()).typeDescriptor();

misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/utils/PackageUtils.java

@@ -262,7 +262,7 @@ public static String[] getQModuleNameParts(String path) {
         String[] moduleParts;
         // Makes the path os-independent, as some of the incoming windows source paths can contain both of the
         // separator types(possibly due to a potential JDI bug).
-        path = path.replaceAll("\\\\", "/");
+        path = path.replace("\\", "/");
         if (path.contains("/")) {
             moduleParts = path.split("/");
         } else {
@@ -349,9 +349,9 @@ private static String getFullModuleName(Document document) {
 
     private static String replaceSeparators(String path) {
         if (path.contains("/")) {
-            return path.replaceAll("/", ".");
+            return path.replace("/", ".");
         } else if (path.contains("\\")) {
-            return path.replaceAll("\\\\", ".");
+            return path.replace("\\", ".");
         }
         return path;
     }

misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/variable/types/BTypeDesc.java

@@ -40,7 +40,7 @@ public String computeValue() {
         try {
             String stringValue = getStringValue(context, jvmValue);
             if (stringValue.startsWith(TYPEDESC_VALUE_PREFIX)) {
-                stringValue = stringValue.replaceAll(TYPEDESC_VALUE_PREFIX, "");
+                stringValue = stringValue.replace(TYPEDESC_VALUE_PREFIX, "");
             }
             return stringValue;
         } catch (Exception e) {

misc/debug-adapter/modules/debug-adapter-runtime/src/main/java/org/ballerinalang/debugadapter/runtime/DebuggerRuntime.java

@@ -366,7 +366,7 @@ public static Object getXMLStepResult(BXml xmlVal, String xmlStepPattern) {
 
     private static BString[] processXMLNamePattern(String xmlNamePattern) {
         // removes LT and GT tokens if presents.
-        xmlNamePattern = xmlNamePattern.replaceAll("<", "").replaceAll(">", "");
+        xmlNamePattern = xmlNamePattern.replace("<", "").replace(">", "");
 
         if (xmlNamePattern.contains(XML_STEP_SEPARATOR)) {
             String[] stepParts = xmlNamePattern.split(XML_ALL_CHILDREN_STEP);

misc/semver-checker/modules/semver-checker-core/src/main/java/io/ballerina/semver/checker/util/SyntaxTreeUtils.java

@@ -49,7 +49,7 @@ public class SyntaxTreeUtils {
      * @return node typename
      */
     public static String getNodeKindName(SyntaxKind nodeKind) {
-        return nodeKind.name().toLowerCase(Locale.ROOT).toLowerCase(Locale.ENGLISH).replaceAll("_", " ");
+        return nodeKind.name().toLowerCase(Locale.ROOT).toLowerCase(Locale.ENGLISH).replace("_", " ");
     }
 
     /**

misc/testerina/modules/testerina-compiler-plugin/src/main/java/org/ballerinalang/testerina/compiler/TestExecutionGenerationTask.java

@@ -248,7 +248,7 @@ private static void gatherMockedFunctions(List<String> mockedFunctionList, Expre
             if ("test".equals(modulePrefix) && "call".equals(methodName)
                     && "when".equals(identifier)) {
                 String mockedFunction = methodCallExpressionNode.arguments()
-                        .get(0).toString().replaceAll("\"", "");
+                        .get(0).toString().replace("\"", "");
                 mockedFunctionList.add(mockedFunction);
             }
         }

misc/testerina/modules/testerina-core/src/main/java/org/ballerinalang/testerina/core/AssertionDiffEvaluator.java

@@ -99,7 +99,7 @@ public static BString getStringDiff(BString actual, BString expected) {
                 }
             }
         }
-        output = output.replaceAll("\n\n", " \n \n ");
+        output = output.replace("\n\n", " \n \n ");
         return StringUtils.fromString(output);
     }
 

misc/testerina/modules/testerina-core/src/main/java/org/ballerinalang/testerina/core/MockAnnotationProcessor.java

@@ -265,7 +265,7 @@ public void process(FunctionNode functionNode, List<AnnotationAttachmentNode> an
                     // Adding `<className> # <functionToMock> --> <MockFnObjectName>` to registry
                     String className = getQualifiedClassName(bLangTestablePackage,
                             functionToMockID.toString(), vals[1]);
-                    vals[1] = vals[1].replaceAll("\\\\", "");
+                    vals[1] = vals[1].replace("\\", "");
                     registry.addMockFunctionsSourceMap(bLangTestablePackage.packageID.getName().toString()
                                     + MODULE_DELIMITER + className + MOCK_LEGACY_DELIMITER + vals[1], functionName);
                 } else {

misc/testerina/modules/testerina-core/src/main/java/org/ballerinalang/testerina/core/TestProcessor.java

@@ -405,7 +405,7 @@ private boolean isGroupAvailable(List<String> inputGroups, List<String> function
      * @return String
      */
     private String getStringValue(Node valueExpr) {
-        return valueExpr.toString().replaceAll("\\\"", "").trim();
+        return valueExpr.toString().replace("\"", "").trim();
     }
 
     /**

misc/testerina/modules/testerina-core/src/main/java/org/ballerinalang/testerina/natives/io/StringUtils.java

@@ -163,7 +163,7 @@ public static Object decode(BString str, BString charset) {
         try {
             String javaStr = str.getValue();
             javaStr = javaStr.replaceAll("%(?![0-9a-fA-F]{2})", "%25");
-            javaStr = javaStr.replaceAll("\\+", "%2B");
+            javaStr = javaStr.replace("+", "%2B");
             return io.ballerina.runtime.api.utils.StringUtils.fromString(
                     URLDecoder.decode(javaStr, charset.getValue()));
         } catch (UnsupportedEncodingException | IllegalArgumentException e) {

misc/testerina/modules/testerina-core/src/main/java/org/ballerinalang/testerina/natives/mock/FunctionMock.java

@@ -112,7 +112,7 @@ private static Object callMockFunction(String originalFunction, String originalC
         if (Thread.currentThread().getStackTrace().length >= 5) {
             String classname = Thread.currentThread().getStackTrace()[4].getClassName();
             if (classname.contains("/")) {
-                classname = classname.replaceAll("/", ".");
+                classname = classname.replace("/", ".");
             }
             String[] projectInfo = classname.split(Pattern.quote("."));
             // Set project info

misc/testerina/modules/testerina-runtime/src/main/java/org/ballerinalang/test/runtime/BTestMain.java

@@ -329,7 +329,7 @@ private static byte[] replaceMethodBody(Method method, Method mockMethod, String
         try {
             InputStream ins;
             if (coverage) {
-                String instrumentedClassPath = instrumentDir + "/" + clazz.getName().replaceAll("\\.", "/") + ".class";
+                String instrumentedClassPath = instrumentDir + "/" + clazz.getName().replace(".", "/") + ".class";
                 ins = new FileInputStream(instrumentedClassPath);
             } else {
                 ins = clazz.getResourceAsStream(clazz.getSimpleName() + ".class");

misc/testerina/modules/testerina-runtime/src/main/java/org/ballerinalang/test/runtime/util/JacocoInstrumentUtils.java

@@ -45,7 +45,7 @@ public static void instrumentOffline(List<URL> projectModuleJarList, Path destDi
         URLClassLoader classLoader = new URLClassLoader(projectModuleJarList.toArray(new URL[0]));
         for (String className : mockClassNames) {
             Class<?> clazz = classLoader.loadClass(className);
-            File file = new File(destDir.toString(), className.replaceAll("\\.", "/") + ".class");
+            File file = new File(destDir.toString(), className.replace(".", "/") + ".class");
             file.getParentFile().mkdirs();
             try (InputStream input = clazz.getResourceAsStream(clazz.getSimpleName() + ".class");
                  OutputStream output = new FileOutputStream(file)) {

misc/testerina/modules/testerina-runtime/src/main/java/org/ballerinalang/test/runtime/util/TesterinaUtils.java

@@ -168,7 +168,7 @@ private static int getTestExecutionState(Class<?> initClazz) {
      */
     public static String formatError(String errorMsg) {
         StringBuilder newErrMsg = new StringBuilder();
-        errorMsg = errorMsg.replaceAll("\n", "\n\t");
+        errorMsg = errorMsg.replace("\n", "\n\t");
         List<String> msgParts = Arrays.asList(errorMsg.split("\n"));
         boolean stackTraceStartFlag = true;