Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from the changes that introduced non-LUKS encryption support #3566

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexgg
Copy link
Contributor

@alexgg alexgg commented Nov 27, 2024


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@alexgg alexgg requested a review from jakogut November 27, 2024 09:05
@alexgg alexgg deployed to balena-staging.com November 28, 2024 12:51 — with GitHub Actions Active
@alexgg
Copy link
Contributor Author

alexgg commented Nov 28, 2024

This seems to still not work in my testing, though it could be unrelated to these changes.

Nov 27 23:40:55 0c2afc1 bash[9627]: ++ get_part_number_by_label vda resin-boot
Nov 27 23:40:55 0c2afc1 bash[9627]: ++ DEVICE=vda
Nov 27 23:40:55 0c2afc1 bash[9627]: ++ LABEL=resin-boot
Nov 27 23:40:55 0c2afc1 bash[9627]: ++ FIELD=label
Nov 27 23:40:55 0c2afc1 bash[9628]: ++ lsblk /dev/vda -nlo name,label
Nov 27 23:40:55 0c2afc1 bash[9629]: ++ grep resin-boot
Nov 27 23:40:55 0c2afc1 bash[9630]: ++ sed -e 's,^vdap\?\([0-9][0-9]*\)[ \t]*resin-boot$,\1,'
Nov 27 23:40:55 0c2afc1 bash[1097]: + efibootmgr --create --disk /dev/ --part 'resin-boot  resin-boot' --label balenaO>
Nov 27 23:40:55 0c2afc1 bash[9631]: invalid numeric value resin-boot  resin-boot
Nov 27 23:40:55 0c2afc1 bash[1097]: + fail 'Failed to run secureboot post installation steps.'
Nov 27 23:40:55 0c2afc1 bash[1097]: + error 'Failed to run secureboot post installation steps.'
Nov 27 23:40:55 0c2afc1 bash[1097]: + PRIORITY=3
Nov 27 23:40:55 0c2afc1 bash[1097]: + log ERROR 'Failed to run secureboot post installation steps.'

@jakogut please try again with the latest changes - re-running tests also now

@alexgg
Copy link
Contributor Author

alexgg commented Nov 28, 2024

New test run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants