Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log power mode and fan profile on unsupported devices, unless set in config.json #3550

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

acostach
Copy link
Contributor

@acostach acostach commented Nov 11, 2024

Supervisor PR balena-os/balena-supervisor#2382 adds log streaming support for os-fan-profile and os-power mode.

To avoid any potential confusion for users with devices which don't support configurable power modes or fan profiles, let's not print any logs from these services unless corresponding settings have been added to config.json


Contributor checklist

  • Changes have been tested
    • Covered in automated test suite
    • [] Manual test case recorded
  • Change-type present on at least one commit
  • Signed-off-by is present
  • The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@flowzone-app flowzone-app bot merged commit db9bac3 into master Nov 13, 2024
157 of 159 checks passed
@flowzone-app flowzone-app bot deleted the acostach/os_power_fan_logging branch November 13, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants