Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module compression #3416

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Module compression #3416

merged 4 commits into from
Jul 19, 2024

Conversation

jakogut
Copy link
Contributor

@jakogut jakogut commented Apr 23, 2024 •
edited
Loading

Enable module compression in the kernel's configuration when supported, as well as in-kernel decompression for a more seamless user experience when loading modules from containers.

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@jakogut jakogut requested a review from alexgg April 24, 2024 18:24
@jakogut jakogut marked this pull request as ready for review April 24, 2024 18:24
@flowzone-app flowzone-app bot enabled auto-merge April 25, 2024 15:12
@jakogut jakogut force-pushed the module-compression branch 2 times, most recently from 76d12f7 to b3fc955 Compare April 25, 2024 19:02
@jakogut jakogut requested a review from alexgg April 25, 2024 19:26
@jakogut
Copy link
Contributor Author

jakogut commented Apr 26, 2024

@resin-jenkins retest this please

1 similar comment
@jakogut
Copy link
Contributor Author

jakogut commented Apr 30, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 14, 2024

@resin-jenkins retest this please

2 similar comments
@jakogut
Copy link
Contributor Author

jakogut commented Jun 15, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 17, 2024

@resin-jenkins retest this please

@jakogut jakogut force-pushed the module-compression branch 2 times, most recently from 0078ca4 to 8a30c70 Compare June 19, 2024 16:16
@jakogut
Copy link
Contributor Author

jakogut commented Jun 20, 2024

@resin-jenkins retest this please

5 similar comments
@jakogut
Copy link
Contributor Author

jakogut commented Jun 24, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 24, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 25, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 26, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 28, 2024

@resin-jenkins retest this please

@jakogut jakogut temporarily deployed to bm.balena-dev.com July 15, 2024 16:44 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to bm.balena-dev.com July 15, 2024 16:48 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to bm.balena-dev.com July 15, 2024 16:48 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to bm.balena-dev.com July 15, 2024 16:52 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to bm.balena-dev.com July 15, 2024 16:52 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to bm.balena-dev.com July 15, 2024 16:52 — with GitHub Actions Inactive
@floion
Copy link
Collaborator

floion commented Jul 16, 2024

@resin-jenkins test this please

@jakogut
kmod: enable zstd
df352c7 
Enable zstd support for kmod to allow modprobe to load compressed
modules.

Change-type: patch
Signed-off-by: Joseph Kogut <joseph@balena.io>
@jakogut
image-balena: support zst compressed modules
77ce253 
Change-type: patch
Signed-off-by: Joseph Kogut <joseph@balena.io>
@jakogut
kernel-balena: enable zstd module compression
3aa66ff 
Enable zstandard module compression in kernels > v5.13, as this feature
was introduced in commit c3d7ef377eb25, first published in that release.

Change-type: major
Signed-off-by: Joseph Kogut <joseph@balena.io>
@jakogut
common: remove module compression bbclass
fbb35d5 
This class is no longer necessary, as the kernel is configured to use
module compression and in-kernel decompression when available.

Change-type: patch
Signed-off-by: Joseph Kogut <joseph@balena.io>
@jakogut
Copy link
Contributor Author

jakogut commented Jul 18, 2024

@resin-jenkins retest this please

@flowzone-app flowzone-app bot merged commit e5ed142 into master Jul 19, 2024
71 of 79 checks passed
@flowzone-app flowzone-app bot deleted the module-compression branch July 19, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floion floion floion approved these changes

@mtoman mtoman Awaiting requested review from mtoman

@acostach acostach Awaiting requested review from acostach

@alexgg alexgg Awaiting requested review from alexgg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakogut @klutchell @floion @alexgg