Add getLatestOsVersions in hostapp model #1062
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
reviewed
Mar 8, 2021
lib/models/hostapp.ts
Outdated
| @@ -227,6 +234,14 @@ const getHostappModel = function (deps: InjectedDependenciesParam) { | |||
| is_invalidated: false, | |||
| }, | |||
| }, | |||
| should_be_running__release: { | |||
There was a problem hiding this comment.
How about creating a separate object, so that we don't retrieve all the data in both methods?
I might be missing something, but it looks like should_be_running__release isn't used anywhere in this file ?!?!
There was a problem hiding this comment.
yes sorry we can remove it, I was testing if it was possible to reuse the same method that handle the owns__release array to also handle should_be_running__releaseand get the latest versions from there. But as far as I can see it's not exactly reliable
Add getLatestOsVersions method in hostapp model Change-type: minor Signed-off-by: Andrea Rosci <andrear@balena.io>
JSReds
force-pushed
the
add-get-latest-os-versions
branch
from
b6885eb
to
79b45e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getLatestOsVersions method in hostapp model
Change-type: minor
Signed-off-by: Andrea Rosci andrear@balena.io
Contributor checklist