Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to SSH over tunnel. #2820

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

robbe-haesendonck
Copy link

To allow for a more easy device management experience for the openbalena users, I "added" the ability to use the tunnel for getting SSH access.

This can be enabled by simply adding the --usetunnel flag, which will tunnel to the device and then open an ssh session over it.

Change-type: minor

To allow for a more easy device management experience for the openbalena users, I "added" the ability to use the tunnel for getting SSH acces. This can be enabled by simply adding the `--usetunnel` flag, which will tunnel to the device and then open an ssh session over it.

Change-type: minor
@robbe-haesendonck
Copy link
Author

Hello balena team!

I was wondering if this is something you'd be willing to pull/merge upstream?

If not I'll close this PR to reduce noise

@myarmolinsky
Copy link
Member

Hi, apologies for not responding to you sooner, somehow this PR missed our radar. We'll review and discuss it and get back to you as soon as possible

@robbe-haesendonck
Copy link
Author

No problem!
Thanks for the reply :)

@myarmolinsky
Copy link
Member

myarmolinsky commented Oct 1, 2024

Hi, apologies for the delay. We have discussed your PR and we have concluded that the ideal solution would actually be to use a tunnel by default for the ssh command, and if the tunnel fails fallback on the current behavior (so no --usetunnel flag should be needed at all for this solution).

If you update your PR with this solution, we would happily review and test it when we have a chance. If you do not, we will look into it at a later date, but we do not have an ETA on when that would be.

@robbe-haesendonck
Copy link
Author

Hi, apologies for the delay. We have discussed your PR and we have concluded that the ideal solution would actually be to use a tunnel by default for the ssh command, and if the tunnel fails fallback on the current behavior (so no --usetunnel flag should be needed at all for this solution).

If you update your PR with this solution, we would happily review and test it when we have a chance. If you do not, we will look into it at a later date, but we do not have an ETA on when that would be.

Thanks for the reply!

I'll pick it up asap and make tunneling the default behaviour and fallback on the current behaviour when tunneling fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants