bug修复及功能支持 #247
Merged
bug修复及功能支持 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cyz-2023
commented
Sep 26, 2024
•
cyz-2023
commented
- sort index使用primary字段
- 多表join支持reorder
- 子查询支持force index
- update语句支持保持ttl
- bug修复
lgqss
requested changes
Nov 15, 2024
src/protocol/network_server.cpp
Outdated
| @@ -834,7 +834,7 @@ static void on_health_check_done(pb::StoreRes* response, brpc::Controller* cntl, | |||
| pb::Status new_status = pb::NORMAL; | |||
| if (cntl->Failed()) { | |||
| if (cntl->ErrorCode() == brpc::ERPCTIMEDOUT || | |||
| cntl->ErrorCode() == ETIMEDOUT) { | |||
| cntl->ErrorCode() == ETIMEDOUT || cntl->ErrorCode() == EHOSTDOWN) { | |||
src/protocol/network_server.cpp
Outdated
| } | ||
| //dead实例不会太多，设置个阈值，太多了则不做处理 | ||
| size_t max_dead_cnt = std::min(info_map.size() / 10 + 1, (size_t)5); | ||
| if (need_cancel_addrs.size() > max_dead_cnt) { | ||
| if (need_cancel_addrs.size() > max_dead_cnt && !is_logical_room_faulty) { |
There was a problem hiding this comment.
而且这个本身状态也没变化，区别就是是否需要cancel rpc，这个只是认为机器卡死的时候需要cancel
cyz-2023
force-pushed
the
master
branch
2 times, most recently
from
fc9e74c
to
8a57dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.