-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested exception support #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekr
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
perf2711
reviewed
Nov 20, 2024
backtrace-library/src/main/java/backtraceio/library/models/BacktraceExceptionHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceExceptionHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceExceptionHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceExceptionHandler.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceExceptionHandler.java
Outdated
Show resolved
Hide resolved
perf2711
reviewed
Nov 22, 2024
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/test/java/backtraceio/library/ReportExceptionTransformerTest.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/test/java/backtraceio/library/ReportExceptionTransformerTest.java
Outdated
Show resolved
Hide resolved
perf2711
approved these changes
Nov 22, 2024
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceReport.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/services/ReportExceptionTransformer.java
Show resolved
Hide resolved
Are you sure that we should mix changing exception to throwable with adding new feature? |
backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceReport.java
Outdated
Show resolved
Hide resolved
lgtm! Good job @konraddysput |
BartoszLitwiniuk
approved these changes
Nov 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This pull request captures nested exception via UncaughtExceptionHandler. In the past, the SDK allowed only capturing a single exception, even if the exception had a cause. This pull request converts an exception chain into a report array with additional attribute identifiers, so the user can see the whole nested exception history.
Example:
ref: BT-5223