Throw exception instead of return null

backtrace-labs · Oct 24, 2024 · 835dd1d · 835dd1d
1 parent 59df612
commit 835dd1d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/backtrace-library/src/main/java/backtraceio/library/models/BacktraceData.java b/backtrace-library/src/main/java/backtraceio/library/models/BacktraceData.java
@@ -173,7 +173,7 @@ public List<String> getAttachmentPaths() {
     public List<String> getAttachments() {
         return this.getAttachmentPaths();
     }
-    
+
     public Map<String, ThreadInformation> getThreadInformationMap() {
         return threadInformationMap;
     }

diff --git a/backtrace-library/src/main/java/backtraceio/library/models/BacktraceStackFrame.java b/backtrace-library/src/main/java/backtraceio/library/models/BacktraceStackFrame.java
@@ -63,8 +63,8 @@ public BacktraceStackFrame(StackTraceElement frame) {
      */
     public static BacktraceStackFrame fromStackTraceElement(StackTraceElement frame) {
         if (frame == null || frame.getMethodName() == null) {
-            BacktraceLogger.w(LOG_TAG, "Frame or method name is null");
-            return null;
+            BacktraceLogger.e(LOG_TAG, "Frame or method name is null");
+            throw new IllegalArgumentException("Frame or method name is null");
         }
         final String functionName = frame.getClassName() + "." + frame.getMethodName();
         final String fileName = frame.getFileName();

diff --git a/backtrace-library/src/test/java/backtraceio/library/models/BacktraceStackFrameTest.java b/backtrace-library/src/test/java/backtraceio/library/models/BacktraceStackFrameTest.java
@@ -43,12 +43,10 @@ public void serializeFromStackTraceElement() {
         assertEquals(expectedJson, json);
     }
 
-    @Test
+    @Test(expected = IllegalArgumentException.class)
     public void createFromNullStackTraceElement() {
         // GIVEN
         BacktraceStackFrame obj = BacktraceStackFrame.fromStackTraceElement(null);
-        // THEN
-        assertNull(obj);
     }
 
     @Test