refactor: add a interface for chain poller #125
Draft
+128
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In currently, the finality provider 's manger and instance use a fixed chain poller to fetch block infos from consumer chain, but for different consumer chain, the poller 's implment maybe very different.
Now the
ChainPoller
struct can work well for eth layer2 or op based layer2, but can not support other layer2 like orbit or zksync, so if we make a service to support orbit based consumer chain, we can not reuse the finality-provider 's code.So we add a interface for chain poller, it can allow other service implment it 's spec poller for other chain. because the manager will create instance in runtime, so we add a chain poller factory interface as a creator.
TODO: in future we can add a mock for chain poller to test some case like consumer chain block reorg.