Konradstaniec/add configurable remote signer #37
Merged
+263
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KonradStaniec
commented
Nov 25, 2024
KonradStaniec
commented
- Adds config option to sue remote signer
- Adds e2e test calling remote signer
KonradStaniec
force-pushed
the
konradstaniec/add-configurable-remote-signer
branch
from
831fbf5
to
c386ef5
Compare
gitferry
approved these changes
Nov 25, 2024
config/config.go
Outdated
| @@ -46,6 +46,10 @@ type Config struct { | |||
| Metrics *MetricsConfig `group:"metrics" namespace:"metrics"` | |||
|
|
|||
| BabylonConfig *BBNConfig `group:"babylon" namespace:"babylon"` | |||
|
|
|||
| UseRemoteSigner bool `long:"use-remotesigner" description:"if true, covenant will use the remote signer to sign transactions"` | |||
There was a problem hiding this comment.
Is it more common to use RemoteSignerEnabled?
There was a problem hiding this comment.
hmm it indeed sounds nicer 👍
KonradStaniec
deleted the
konradstaniec/add-configurable-remote-signer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.