F/consumer rewards e2e #301
Open
+379
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
requested review from
gitferry and
KonradStaniec
and removed request for
a team
| @@ -30,7 +30,10 @@ cosmos-relayer-rmi: | |||
| docker rmi babylonlabs-io/cosmos-relayer 2>/dev/null; true | |||
|
|
|||
| build-ibcsim-bcd: | |||
| docker build --tag babylonlabs-io/ibcsim-bcd -f ibcsim-bcd/Dockerfile ${BABYLON_FULL_PATH} | |||
| cp -a $(BABYLON_FULL_PATH)/babylon-sdk/ $(BABYLON_FULL_PATH)/contrib/images/ibcsim-bcd | |||
There was a problem hiding this comment.
Wdyt we use git clone for getting babylon-sdk repo to a gitignore-ed directory, instead of a submodule? suggesting this as submodules are quite troublesome due to those git submodule init and git submodule update stuff
|
|
||
| // Ensure consumer rewards are generated and sent to the staking contract | ||
| s.Eventually(func() bool { | ||
| rewards, err := s.cosmwasmController.QueryStakingContractBalances() |
|
Btw, shall we create a Github issue for moving the entire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rewards generation e2e test.
This first adapts / fixes the existing e2e tests to work with the new multi-contract setup.
Uses a sub-module to build the
ibcsim-bcdcontainer from thebabylon-sdkreference; which is something that can clearly be improved. Perhaps in a follow-up?Also, there are some (unrelated to staking integration) e2e tests that are failing. Commented them out in the
test-e2eMakefile target. Sorted out this target so that is both up-to-date and depending on other existing targets, for robustness.CI should use these targets as well. Perhaps in a follow-up?