fix dependencies #11
fix dependencies #11
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
demo/app/app.go
Outdated
| var icaHostStack porttypes.IBCModule | ||
| icaHostStack = icahost.NewIBCModule(app.ICAHostKeeper) | ||
| icaHostStack = ibcfee.NewIBCMiddleware(icaHostStack, app.IBCFeeKeeper) | ||
| // // Create Interchain Accounts Stack |
There was a problem hiding this comment.
Double comments are not nice.
demo/app/app.go
Outdated
| // icahost "github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/host" | ||
| // icahostkeeper "github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/host/keeper" | ||
| // icahosttypes "github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/host/types" | ||
| // icatypes "github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/types" | ||
| ibcfee "github.com/cosmos/ibc-go/v8/modules/apps/29-fee" |
There was a problem hiding this comment.
Put a TODO / FIXME / comment here?
I wonder why the ica stuff worked before btw.
And finally, perhaps the ica disabling stuff should be done in a different PR. So that it can ve reverted cleanly, by example.
| github.com/cosmos/gogogateway v1.2.0 // indirect | ||
| github.com/cosmos/gogoproto v1.4.12 | ||
| github.com/cosmos/iavl v1.1.2 // indirect | ||
| github.com/cosmos/ibc-go/v8 v8.0.0 | ||
| github.com/cosmos/ibc-go/v8 v8.3.2 |
There was a problem hiding this comment.
Perhaps this broke the ica stuff? 🤷🏼
There was a problem hiding this comment.
I tried v8.0.0 and it does not make any difference, weird
There was a problem hiding this comment.
Likely v8.3.x is being pulled through the dependency tree.
There was a problem hiding this comment.
That, or the change comes from somewhere else (cosmos-sdk).
|
E2E tests are still failing though. |
This reverts commit ef4412d.
|
Agreed, let's dedicate this PR for fixing dependencies. Will create another PR for fixing CI / removing ICA after this one |
NOTE: commented out interchain account it's not used at the moment and the module panicks in e2e test.