Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add loadPartialConfig info in README #854

Conversation

gaurav5430
Copy link

@gaurav5430 gaurav5430 commented Jun 22, 2020

To make it more clear that the options specified here override the existing babel config/

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:
    changes to README

What is the current behavior? (You can also link to an open issue here)
N/A

What is the new behavior?
remains the same

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:
related to #823

To make it more clear that the options specified here override the existing babel config/
@kylemh
Copy link

kylemh commented Jul 13, 2020

I appreciate the added documentation, but writing "Kind of fixes #823" ensures this PR's merge will close that ticket. I don't believe this resolves the root problem I'm outlining in the issue.

@gaurav5430
Copy link
Author

I appreciate the added documentation, but writing "Kind of fixes #823" ensures this PR's merge will close that ticket. I don't believe this resolves the root problem I'm outlining in the issue.

Sure, removed that.
Thanks.

@JLHwung
Copy link
Contributor

JLHwung commented Jul 11, 2024

Closing this PR. This will be addressed in #909

@JLHwung JLHwung closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants