Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce resourcePrefix on Android library modules #123

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Enforce resourcePrefix on Android library modules #123

merged 4 commits into from
Feb 15, 2024

Conversation

azrael8576
Copy link
Owner

Thank you for opening a Pull Request!
Before submitting your PR, please make sure you:

  • Include a PR description which states what you've done and why
  • Open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass (./gradlew --init-script gradle/init.gradle.kts spotlessApply to automatically apply formatting)
  • [] Update any relevant documentation

Are you a first-time contributor?

  • Ensure you've read and understood the contributing guidelines
  • Familiarize yourself with the project structure and the codebase

Fixes #122 🦕

@azrael8576 azrael8576 added the enhancement New feature or request label Feb 15, 2024
@azrael8576 azrael8576 self-assigned this Feb 15, 2024
@azrael8576
fix lint errors
17882ba
@azrael8576
Enforce resourcePrefix on Android library modules (fixed #122)
df3fc7d 
```
:core:network -> core_network_
:core:data -> core_data_
:core:common -> core_common_
:core:model -> core_model_
:core:domain -> core_domain_
:core:designsystem -> core_designsystem_
:core:testing -> core_testing_
:core:datastore -> core_datastore_
:core:datastore-proto -> core_datastore_proto_
:core:datastore-test -> core_datastore_test_
:core:data-test -> core_data_test_

:ui-test-hilt-manifest -> ui_test_hilt_manifest_

:feature:login -> feature_login_
:feature:teacherschedule -> feature_teacherschedule_
:feature:contactme -> feature_contactme_
:feature:home -> feature_home_
```
@azrael8576
fix spotless issues
1025868
@azrael8576 azrael8576 marked this pull request as ready for review February 15, 2024 08:28
@azrael8576 azrael8576 merged commit 45855fa into main Feb 15, 2024
4 checks passed
@azrael8576 azrael8576 deleted the chore/lint branch February 15, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azrael8576 azrael8576

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Enforce resourcePrefix on Android library modules
1 participant
@azrael8576