Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce overall build complexity #108

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

azrael8576
Copy link
Owner

  • Correctly configure the visibility of dependencies:
    • api when it's part of it's public api
    • implementation when it's part of it's internal implementation
  • Remove unnecessary dependencies in build.gradle.kts files
  • Remove unnecessary dependencies provided by plugins
  • Remove unnecessary applied plugins (i.e. roborazzi)
  • Sort dependencies in build.gradle.kts
  • Delete unused entries in libs.versions.toml

name: Pull request
about: Create a pull request
label: 'triage me'

Thank you for opening a Pull Request!
Before submitting your PR, please make sure you:

  • Include a PR description which states what you've done and why
  • Open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass (./gradlew --init-script gradle/init.gradle.kts spotlessApply to automatically apply formatting)

Are you a first-time contributor?

  • Ensure you've read and understood the contributing guidelines
  • Familiarize yourself with the project structure and the codebase

- Correctly configure the visibility of dependencies:
  - `api` when it's part of it's public `api`
  - `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
@azrael8576 azrael8576 added the setup improvement Suggestions or changes related to the project's configuration and initial setup. label Jan 29, 2024
@azrael8576 azrael8576 self-assigned this Jan 29, 2024
@azrael8576 azrael8576 marked this pull request as ready for review January 29, 2024 14:12
@azrael8576 azrael8576 merged commit 426bd96 into main Jan 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setup improvement Suggestions or changes related to the project's configuration and initial setup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant