refactor(optimizer): use optimizer_cls_and_kwargs
for custom optim
#2012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
alternate_optimizer
. Move to useoptimizer
instead to consolidate.Description
Refactors the optimizer handling to offload from
create_optimizer
into the Trainer instead. Onlylora_plus
requires overriding that function now.ao_adamw_4bit
is available ontransformers
asadamw_torch_4bit
.lion_pytorch
is available ontransformers
aslion_32bit
.loraplus_lr_embedding
to let it inherit from Model Input class insteadTODO:
adamw_anyprecision
is not affectedoptimi
optimizers https://optimi.benjaminwarner.dev/which_optimizer/Motivation and Context
This is due to upstream PR opening a new config huggingface/transformers#34358
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)
Next steps
Once some time passes:
lion_pytorch
and remove the dependency