Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 on openapi spec #148

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dimmaski
Copy link

@dimmaski dimmaski commented Mar 3, 2022

I'm running into issues when running the following command, against an API generated by fastapi-crudrouter (which is great btw 🥇 )

>> openapi-generator validate -i http://127.0.0.1:8000/openapi.json
Validating spec (http://127.0.0.1:8000/openapi.json)
Errors:
	- attribute paths.'/tag/{item_id}'(get).responses.404.detail is unexpected
	- attribute paths.'/project/{item_id}'(get).responses.404.detail is unexpected
	- attribute paths.'/tag/{item_id}'(delete).responses.404.detail is unexpected
	- attribute paths.'/project/{item_id}'(delete).responses.404.detail is unexpected
	- attribute paths.'/project/{item_id}'(put).responses.404.detail is unexpected
	- attribute paths.'/tag/{item_id}'(put).responses.404.detail is unexpected

[error] Spec has 6 errors.

I believe this PR resolves #105. Picking up on the great example left by @sondrelg at #104.

I believe this should also help resolve this PR #141.

@vercel
Copy link

vercel bot commented Mar 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/wjdX8HyZ9AsH8dj8cCqgaxWhnvpm
✅ Preview: https://fastapi-crudrouter-git-fork-dimmaski-105-404-openapi-fix-flortz.vercel.app

@mitaka
Copy link

mitaka commented Apr 4, 2022

I can confirm that this is an issue. Can you please fix the lint issue?

@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
fastapi-crudrouter ✅ Ready (Inspect) Visit Preview May 31, 2022 at 7:42PM (UTC)

@dimmaski
Copy link
Author

@mitaka, giving it a try :)

@vercel
Copy link

vercel bot commented Jan 29, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @awtkns on Vercel.

@awtkns first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing schemathesis validation
3 participants