-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add & improve concurrent tests #1820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add concurrent tests * Add missing 100x to a test's name * Remove 100MiB file and generate file instead. * See if using UUID for filename fixes this possibly-concurrency-issue. * Try temporaryDirectory property. * Fix concurrency issue * Comment fixes & remove STS getCallerIdentity concurrent calls. * Remove unused import * Remove concurrent test for event stream output * Refactor tests a bit * Use FileStream to write to file * Swap out filemanager with writing emtpy data approach * Tweak a bit * Simplify; no need to safe generated dummy data to a file, just use 50MB memory. * Change from 10x50MB to 100x5MB * Reduce payload from 5MB to 3MB * Reduce payload from 3MB to 1MB. * Add test for 1.5 MB to test aws chunked & flexible checksum flow also. --------- Co-authored-by: Sichan Yoo <chanyoo@amazon.com> Co-authored-by: Josh Elkins <jbelkins@users.noreply.github.com>
… tests on URLSessionHTTPClient
…_concurrent_tests
jbelkins
changed the title
Jbe/20241113 reenable concurrent tests
chore: Add & improve concurrent tests
Nov 13, 2024
sichanyoo
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
S3Concurrency tests:
URLSessionHTTPClient
as well as on Linux & the CRT clientTranscribeStreaming tests:
note: A tracking ticket will be written for the CRT HTTP client not passing bidirectional streaming concurrency tests
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.