feat: Support generating presigned url for UploadPart operation #1809
+268
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After 9e3244e the generated URL's are correct and uploading works :). Will look into writing tests for this now. |
2 tasks
plu
commented
Nov 1, 2024
Comment on lines
+32
to
+39
| if let partNumber = input.partNumber { | ||
| let queryItem = Smithy.URIQueryItem(name: "partNumber".urlPercentEncoding(), value: Swift.String(partNumber).urlPercentEncoding()) | ||
| builder.withQueryItem(queryItem) | ||
| } | ||
| if let uploadId = input.uploadId { | ||
| let queryItem = Smithy.URIQueryItem(name: "uploadId".urlPercentEncoding(), value: Swift.String(uploadId).urlPercentEncoding()) | ||
| builder.withQueryItem(queryItem) | ||
| } |
There was a problem hiding this comment.
Wondering if there is a way to generate this.
plu
changed the title
plu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds methods to generate a presigned url for the
UploadPartoperation.Issue
Fixes #1808, #723
Description of changes
It generates two new methods:
UploadPartInput.presignURL(config:expiration:)S3Client.presignedURLForUploadPart(input:expiration:)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.