Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SSO credentials provider #1084

Merged
merged 13 commits into from
Aug 25, 2023
Merged

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Aug 15, 2023

Adds wrapper for CRT's SSO credentials provider implementation.

Issue #

#236

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sichanyoo sichanyoo changed the title Feat/sso credentials provider feat: Add SSO credentials provider Aug 16, 2023
@sichanyoo
Copy link
Contributor Author

/test

Copy link
Collaborator

@dayaffe dayaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good! Just mentioning some test comments that Josh gave me on my ProcessCredentialsProvider CR

@sichanyoo
Copy link
Contributor Author

/test

@sichanyoo sichanyoo force-pushed the feat/sso-credentials-provider branch from ee53498 to ca148c6 Compare August 18, 2023 21:29
Copy link
Collaborator

@dayaffe dayaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sichanyoo
Copy link
Contributor Author

/test

1 similar comment
@sichanyoo
Copy link
Contributor Author

/test

@sichanyoo
Copy link
Contributor Author

/test

@sichanyoo
Copy link
Contributor Author

/test

@jbelkins jbelkins self-requested a review August 25, 2023 19:28
@sichanyoo sichanyoo merged commit ba96f5f into main Aug 25, 2023
10 checks passed
@sichanyoo sichanyoo deleted the feat/sso-credentials-provider branch August 25, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants