Use the objects API for directory download/upload #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Nov 18, 2024
graebm
reviewed
Nov 27, 2024
| @@ -6,12 +6,15 @@ edition = "2021" | |||
| [dependencies] | |||
|
|
|||
| # Swap which line is commented-out to use GitHub or local aws-s3-transfer-manager | |||
| aws-s3-transfer-manager = { git = "https://github.com/awslabs/aws-s3-transfer-manager-rs.git", rev = "790ead476a104cf0b66fdd00b5b9c3636321b244" } | |||
| aws-s3-transfer-manager = { git = "https://github.com/awslabs/aws-s3-transfer-manager-rs.git", rev = "e48ef1b0cb573bd7dbb99d426824587bfc73270a" } | |||
There was a problem hiding this comment.
there are 3 newer commits (latest is 06c087a5d53676bb048f6c512b8eb1fda63f03d5)
use one of those if you can
There was a problem hiding this comment.
looks like there are some api change
waahm7
reviewed
Nov 27, 2024
| match &self.handle.transfer_path { | ||
| Some(transfer_path) => { | ||
| // Use the objects API to download/upload directory directly | ||
| match workload_config.tasks[0].action { |
There was a problem hiding this comment.
What if first task is download but second is upload?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.