Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This Version update will provide a fit_predict method #40

Merged
merged 9 commits into from
Dec 3, 2023
Merged

Conversation

momonga-ml
Copy link
Contributor

@momonga-ml momonga-ml commented Nov 22, 2023

Summary

Add predict method based on the combine method for ensemble.
When ensemble is selected, Denseclus does not combine the umaps, instead it fits clusterer for each UMAP.
When predict is called it used approximate_predict in HDSCAN to then vote on the cluster assignment.

Other changes

  • Change default method from 'contrast' to 'intersection'
  • Change default distance metric for categoricals to jaccard for later rapids integration
  • Increase overall test coverage
  • prediction_data=False for combined UMAPs, True for ensemble
  • Update examples to reflect changes

See: #4 and #33

@momonga-ml momonga-ml added the enhancement New feature or request label Nov 22, 2023
This was linked to issues Nov 22, 2023
@momonga-ml momonga-ml self-assigned this Nov 22, 2023
@momonga-ml momonga-ml changed the title This Version update will provide a predict method This Version update will provide a fit_predict method Nov 22, 2023
@momonga-ml momonga-ml merged commit 658c2b0 into main Dec 3, 2023
1 check passed
@momonga-ml momonga-ml deleted the v0.2.0 branch December 3, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Prediction on new points Fit Predict method
1 participant