Fixed the route parsing logic by caching the httpContext object #309
Annotations
21 warnings
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AWS.Distro.OpenTelemetry.AutoInstrumentation.csproj : warning NU1701: Package 'OpenTelemetry.Instrumentation.AspNet 1.9.0-beta.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project.
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AWS.Distro.OpenTelemetry.AutoInstrumentation.csproj : warning NU1701: Package 'OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule 1.9.0-beta.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project.
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AWS.Distro.OpenTelemetry.AutoInstrumentation.csproj : warning NU1701: Package 'OpenTelemetry.Instrumentation.AspNet 1.9.0-beta.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project. [/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests.csproj]
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AWS.Distro.OpenTelemetry.AutoInstrumentation.csproj : warning NU1701: Package 'OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule 1.9.0-beta.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project. [/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests.csproj]
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests.csproj : warning NU1701: Package 'OpenTelemetry.Instrumentation.AspNet 1.9.0-beta.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net8.0'. This package may not be fully compatible with your project.
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests.csproj : warning NU1701: Package 'OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule 1.9.0-beta.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net8.0'. This package may not be fully compatible with your project.
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AWS.Distro.OpenTelemetry.AutoInstrumentation.csproj : warning NU1701: Package 'OpenTelemetry.Instrumentation.AspNet 1.9.0-beta.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project. [TargetFramework=net6.0]
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AWS.Distro.OpenTelemetry.AutoInstrumentation.csproj : warning NU1701: Package 'OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule 1.9.0-beta.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net6.0'. This package may not be fully compatible with your project. [TargetFramework=net6.0]
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/Version.cs(6,14): warning SA1400: Element 'Version' should declare an access modifier (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1400.md) [/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AWS.Distro.OpenTelemetry.AutoInstrumentation.csproj::TargetFramework=net6.0]
|
|
Build on Linux
/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/Version.cs(8,26): warning SA1401: Field should be private (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1401.md) [/home/runner/work/aws-otel-dotnet-instrumentation/aws-otel-dotnet-instrumentation/src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AWS.Distro.OpenTelemetry.AutoInstrumentation.csproj::TargetFramework=net6.0]
|
|
Test on Linux:
src/AWS.Distro.OpenTelemetry.AutoInstrumentation/AssemblyInfo.cs#L7
Single-line comment should be preceded by blank line (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1515.md)
|
|
Test on Linux:
src/AWS.Distro.OpenTelemetry.AutoInstrumentation/Version.cs#L6
Element 'Version' should declare an access modifier (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1400.md)
|
|
|
|
Test on Linux:
src/AWS.Distro.OpenTelemetry.AutoInstrumentation/Version.cs#L8
Field 'version' should begin with upper-case letter (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1307.md)
|
|
Test on Linux:
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AwsMetricAttributesSpanProcessorTest.cs#L238
Cannot convert null literal to non-nullable reference type.
|
|
Test on Linux:
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AttributePropagatingSpanProcessor.cs#L26
Non-nullable field 'tracer' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
|
|
Test on Linux:
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AwsMetricAttributesGeneratorTest.cs#L47
Possible null reference assignment.
|
|
Test on Linux:
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AwsMetricAttributesGeneratorTest.cs#L39
Non-nullable field 'spanDataMock' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
|
|
Test on Linux:
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AwsMetricAttributesGeneratorTest.cs#L39
Non-nullable field 'parentSpan' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
|
|
Test on Linux:
test/AWS.Distro.OpenTelemetry.AutoInstrumentation.Tests/AwsMetricAttributesGeneratorTest.cs#L60
Possible null reference assignment.
|
Loading