Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs and Table to reflect appropriate information #223

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ If you’re an open source observability user or contributor, we invite you to g
* Ask a question by filing an [issue](https://github.com/aws-observability/aws-otel-community/issues).
* File a bug by filing a [pull request (PR)](https://github.com/aws-observability/aws-otel-community/pulls).
* Contribute an enhancement or a feature which you need and maintainers will be happy to code review. You can open an issue to discuss the design of your proposed enhancement and then file a PR.
* If you’re just getting started, we welcome you to get started with issues tagged as “good first issues” and join [Gitter](https://gitter.im/aws-otel-distro/community) to ask maintainers and other developers any questions you may have.
* If you’re just getting started, we welcome you to get started with issues tagged as “good first issue”.
vasireddy99 marked this conversation as resolved.
Show resolved Hide resolved
* Join the awesome upstream OpenTelemetry project [community](https://github.com/open-telemetry/community). Participate in the OpenTelemetry [SIG meetings](https://github.com/open-telemetry/community#calendar) where observability experts meet and discuss the OpenTelemetry specification and implementation of observability components. And the code is open source - so contribute to OpenTelemetry!

## AWS Distro for OpenTelemetry (ADOT) Public Preview Program
Expand Down
16 changes: 8 additions & 8 deletions language_parity_chart.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ These charts outline the various language library components and features implem
|--- |--- |--- |--- |--- |--- |
|AWS X-Ray Trace ID generation |Done |Done |Done |Done |Done |
|AWS X-Ray Trace ID propogation and trace header web framework handling |Done |Done |Done |Done |Done |
|Basic support for tracing call to AWS using language AWS SDK |Done |Done |In progress |Done |In progress |
|Basic support for tracing call to AWS using language AWS SDK |Done |Done |Done |Done |Done |
|Library metadata |Done |Done |Done |Done |Done |
|DB/SQL support |Done |Done |In review |In review ([OTel Issue #159](https://github.com/open-telemetry/opentelemetry-python-contrib/issues/159)) |Done |
|AWS X-Ray errors/exceptions format |Done (via ADOT Collector) |Done (via ADOT Collector) |In OTel, need traslation done in collector |Done (via ADOT Collector) |Needs implementation in OTel ([OTel issue #1491](https://github.com/open-telemetry/opentelemetry-go/issues/1491)) |
|AWS X-Ray errors/exceptions format |Done (via ADOT Collector) |Done (via ADOT Collector) |Done (via ADOT Collector) |Done (via ADOT Collector) |Done (via ADOT Collector) |
|Resource Detectors - AWS Elastic Beanstalk |Done |Done |EC2 (through ADOT Collector) |EC2 (through ADOT Collector) |Done |
|Resource Detectors - AWS EC2 |Done |Done |EC2 (through ADOT Collector) |EC2 (through ADOT Collector) |Done |
|Resource Detectors - AWS ECS |Done |Done |Partial (through ADOT Collector) <br/> Container ID not recorded |Partial (through ADOT Collector) <br/> Container ID not recorded |Done |
|Resource Detectors - AWS EKS |Done |Done |Partial (through ADOT Collector)|Partial (Through ADOT Collector)|Done |
|AWS X-Ray Trace ID injection into application logs |Done | | | | |
|Metadata/Annotations |Done (through ADOT Collector) |Done (through ADOT Collector) |Done (through ADOT Collector) |Done (through ADOT Collector) |Done (Through Collector) |
|AWS Lambda support | | | |Done (with autoinstumentation) | |
|Auto-instumentation |Done |Needs implementation in OTel |Needs implementation in OTel |Done |Needs implementation in OTel |
|Resource Detectors - AWS ECS |Done |Done |Done |Done |Done |
|Resource Detectors - AWS EKS |Done |Done |Done |Done |Done |
|AWS X-Ray Trace ID injection into application logs |Done | NA | NA | NA | NA |
vasireddy99 marked this conversation as resolved.
Show resolved Hide resolved
|Metadata/Annotations |Done (through ADOT Collector) |Done (through ADOT Collector) |Done (through ADOT Collector) |Done (through ADOT Collector) |Done (Through ADOT Collector) |
|AWS Lambda support |Done |Done | NA |Done (with auto-instrumentation) | NA |
vasireddy99 marked this conversation as resolved.
Show resolved Hide resolved
|Auto-instrumentation |Done |Done |Needs implementation in OTel |Done |Needs implementation in OTel |
Copy link
Member

@mhausenblas mhausenblas Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure that wherever we have "Needs implementation in OTel" there is a link to the upstream issue to aid tracking?

Copy link
Contributor Author

@vasireddy99 vasireddy99 Jan 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For NodeJS, I see that aws-sdk and aws-lambda and not any specific issues to it.
Would like to double check if we are reflecting right status, if not I can modify the status for this DONE.

For .Net - We have listed a TODO in the docs, but couldn't find any tracking issue or dicsussions.

cc'ing @willarmiros to help with any info that we might be missing here about tracking issues.