Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch "stack is in failed state, you may need to delete it from AWS Console" (DELETE_FAILED) #2265

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ShadowCat567
Copy link
Contributor

Problem

Mapping destroy failed errors from CDK that have to do with a stack being a failed state and some resources needing manual attention before deletion can occur.

Issue number, if available:
N/A

Changes

Update to CDK error mapping

Validation

Updated CDK error mapping test

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: b227c83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/backend-deployer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ShadowCat567 ShadowCat567 marked this pull request as ready for review November 22, 2024 21:39
@ShadowCat567 ShadowCat567 requested a review from a team as a code owner November 22, 2024 21:39
@ShadowCat567 ShadowCat567 changed the title Catch stack is in failed state, you may need to delete it from AWS Console (DELETE_FAILED) Catch "stack is in failed state, you may need to delete it from AWS Console" (DELETE_FAILED) Nov 22, 2024
humanReadableErrorMessage:
'The CloudFormation deletion failed due to {stackName} being in DELETE_FAILED state. Ensure all your resources are able to be deleted',
resolutionMessage:
'The following resource(s) failed to delete: {resources}. Ensure they are in a state where they can be deleted. Find more information in the CloudFormation AWS Console for this stack.',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current message that is produced by the fault has both the resources that caused the failed deletion as well as how to get those resources into a state where they can be deleted, would like to find a way to get that information into the resolution message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant