Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specifically catch AppSync 'Code contains one or more errors' #2264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Amplifiyer
Copy link
Contributor

Problem

This error The code contains one or more errors is thrown during both CFN deployment and hotswap but the error message differs.

Issue number, if available:

Changes

Specifically catch and map this error and make the top level error message more meaningful.

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Amplifiyer Amplifiyer requested a review from a team as a code owner November 22, 2024 17:33
Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 2fea433

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/backend-deployer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines -317 to -330
{
// Error: .* is printed to stderr during cdk synth
// Also extracts the first line in the stack where the error happened
errorRegex: new RegExp(
`^Error: (.*${this.multiLineEolRegex}.*at.*)`,
'm'
),
humanReadableErrorMessage:
'Unable to build the Amplify backend definition.',
resolutionMessage:
'Check your backend definition in the `amplify` folder for syntax and type errors.',
errorName: 'BackendSynthError',
classification: 'ERROR',
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just moved down in the order to catch more "generic" errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant